Label color #2014

ActiveChooN · 2020-08-11T09:51:30Z

Motivation and context

This PR helps user to change predefined label color. When creating a label, it is assigned a color from a color map. Also ability to change this color from UI is available.

Resolve #1480, resolve #1572, closes #842

How has this been tested?

Manually

Checklist

I submit my changes into the develop branch
I have added description of my changes into CHANGELOG file
~~- [ ] I have updated the documentation accordingly~~
~~- [ ] I have added tests to cover my changes~~
I have linked related issues (read github docs)
I have increased versions of npm packages if it is necessary (cvat-canvas,
cvat-core, cvat-data and cvat-ui)

License

I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.
I have updated the license header for each file (see an example below)

# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

cvat/apps/engine/migrations/0026_labelcolor.py

zhiltsov-max · 2020-08-11T10:49:09Z

cvat/apps/dataset_manager/formats/utils.py

+            colors[label] = tuple(map(int, color.split(',')))
+    return colors
+
+def normalize_label(label):


The function is not used anymore, but it should be to avoid problems with symbol case and special characters.

The logic is:

sort labels to provide stable results (across different tasks with same labels)

find matching labels using normalization

if have conflicts, the first match uses the table

generate random colors for the rest

Now colors are set at the time of label creation. So i guess sorting by its name can not provide stable result now. I can not create labels with the same name, so are there any conflicts?

Conflicts appear from labels like BACKGROUND, _BA_CK_gro_und_, back_GROUND etc after their normalization. I feel that sorting might be unnecessary anymore, or should be done in label creation code, when it is done in batch mode.

cvat/apps/dataset_manager/formats/mask.py

coveralls · 2020-08-11T11:52:34Z

Pull Request Test Coverage Report for Build 7036

55 of 66 (83.33%) changed or added relevant lines in 4 files are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.007%) to 69.729%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
cvat/apps/engine/serializers.py	11	12	91.67%
cvat/apps/dataset_manager/formats/utils.py	42	52	80.77%

Files with Coverage Reduction	New Missed Lines	%
src/labels.js	4	82.86%

Totals
Change from base Build 6998:	0.007%
Covered Lines:	11750
Relevant Lines:	16392

💛 - Coveralls

zhiltsov-max

I feel like some kind of a button to cancel current label color changes could be useful somewhere around the palette

Looks good.

bsekachev · 2020-08-13T08:01:25Z

@ActiveChooN

When we change label color on the annotation view (Enter shortcut), is it expected to be changed on a server?
Annotation view color picker still has default preset of colors, are you planning to change it?

nmanovic · 2020-08-17T17:54:49Z

@ActiveChooN ,

What is the status of the PR?

Several comments from my side:

Need to have a button "OK" when you select a color, "Cancel", and "Reset to default"
"Label color" should be replaced by a color pictogram. Color feedback is important.
Check with Maxim why road is turquoise by default? It looks unusual.

ActiveChooN · 2020-08-17T18:05:13Z

@nmanovic, finishing work on annotation view. I'm totally agree about "reset to default". But changing color proceed immediately after picking. So I don't think button "Ok" is necessary. What do you think?

nmanovic · 2020-08-17T18:16:37Z

finishing work on annotation view. I'm totally agree about "reset to default". But changing color proceed immediately after picking. So I don't think button "Ok" is necessary. What do you think?

I think that need to replace "Label color" by a color pictogram for sure. I think that colors for default labels should be reviewed one more time. Also press X isn't intuitive way to choose a color.

nmanovic · 2020-08-17T18:21:02Z

@ActiveChooN , looks like colors of labels are not matched between the task view and annotation view. Is it something you are working right now?

nmanovic · 2020-08-17T18:36:20Z

Let's add a similar menu:

nmanovic · 2020-08-18T08:47:45Z

Create new task dialog:

Use color picker icon instead of “Label color”
The color picker should show the current color

Color picker dialog:

It should have “OK”, “Cancel” and “Reset” buttons (see Gimp screenshot)

Job view:

Use “color by” == “label” by default
Use color picker dialog implemented for create new task dialog
Use color picker icon to choose a color
You can choose color only if “color by” equals to “instance” or “group”. Thus “Enter” and “color picker” is enabled only when “color by” != “label”.
Don't save selected colors on the server

…dk/label-color

nmanovic · 2020-08-19T21:21:26Z

cvat/apps/engine/migrations/0028_labelcolor.py

+
+    for task in Task.objects.all():
+        labels = Label.objects.filter(task_id=task.id)
+        normalized_names = [normalize_label(l.name) for l in labels]


I see the code in 3 places. Need to remove code cloning because the logic isn't trivial.

Will Road and road have the same color? Is it OK to have the same color for different classes?

@nmanovic, sorry for a long wait. Realized that default python hash function has a random seed every run and colors weren't consistent.

I see the code in 3 places. Need to remove code cloning because the logic isn't trivial.

Done.

Will Road and road have the same color? Is it OK to have the same color for different classes?

If that labels will appear in the task only once they will have the same color. But if label will appear in the task more than one time, for the first label color will be taken from the color map and color will be calculated with hash for others.

bsekachev · 2020-08-21T14:09:44Z

In this patch I can change colors (when Color by set to instance) only using shortcut. UI controls don't work.

ActiveChooN added 6 commits July 23, 2020 16:24

added color to django app and cvat-core

4cb4d2a

temp

eadebbe

temp

3d16e88

Added label color to mask dump

ef03a31

Fixed UI for label color picker

6b239b4

Merge branch 'develop' into dk/label-color

5c81093

ActiveChooN added the enhancement New feature or request label Aug 11, 2020

ActiveChooN requested review from bsekachev, nmanovic and zhiltsov-max as code owners August 11, 2020 09:51

zhiltsov-max requested changes Aug 11, 2020

View reviewed changes

zhiltsov-max reviewed Aug 11, 2020

View reviewed changes

cvat/apps/dataset_manager/formats/mask.py Show resolved Hide resolved

ActiveChooN added 4 commits August 11, 2020 14:14

Merge branch 'develop' into dk/label-color

b458eb7

npm packages and CHANGELOG

00bbb05

fixed models and migrations

d4fe004

Fixed default background color and using normalization

191f019

Added setting label color with hash

9ecfa18

ActiveChooN requested a review from zhiltsov-max August 12, 2020 14:57

zhiltsov-max reviewed Aug 12, 2020

View reviewed changes

zhiltsov-max previously approved these changes Aug 12, 2020

View reviewed changes

fixed error

d793fa7

ActiveChooN dismissed zhiltsov-max’s stale review via d793fa7 August 12, 2020 21:59

Added close icon to color picker

03b2d4f

bsekachev previously approved these changes Aug 13, 2020

View reviewed changes

ActiveChooN changed the title ~~Label color~~ [WIP] Label color Aug 13, 2020

Fixed CHANGELOG

dff5d05

ActiveChooN dismissed bsekachev’s stale review via dff5d05 August 14, 2020 21:13

Merge branch 'develop' into dk/label-color

9513224

ActiveChooN added 2 commits August 19, 2020 09:35

requested changes

82f89ed

Merge branch 'dk/label-color' of https://github.com/opencv/cvat into …

10e0367

…dk/label-color

ActiveChooN changed the title ~~[WIP] Label color~~ Label color Aug 19, 2020

ActiveChooN added 2 commits August 19, 2020 11:32

fixed menu visibility

9429c54

Merge branch 'develop' into dk/label-color

fb1f617

nmanovic reviewed Aug 19, 2020

View reviewed changes

ActiveChooN added 2 commits August 20, 2020 15:57

Fixed label hashing and algorithm

9543913

Added wheel package to CI

1251b95

ActiveChooN requested a review from azhavoro as a code owner August 20, 2020 13:22

ActiveChooN added 4 commits August 20, 2020 16:29

Fixed dockerfile

38174bd

moved wheel package from dockerfile to requirements

4012750

fixed requirements

cf3c569

Fixed requirements

384fa26

bsekachev approved these changes Aug 21, 2020

View reviewed changes

bsekachev merged commit bee4c37 into develop Aug 21, 2020

ActiveChooN deleted the dk/label-color branch August 24, 2020 10:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Label color #2014

Label color #2014

ActiveChooN commented Aug 11, 2020 •

edited

Loading

zhiltsov-max Aug 11, 2020

ActiveChooN Aug 11, 2020

zhiltsov-max Aug 11, 2020

coveralls commented Aug 11, 2020 •

edited

Loading

zhiltsov-max left a comment •

edited

Loading

bsekachev commented Aug 13, 2020

nmanovic commented Aug 17, 2020 •

edited

Loading

ActiveChooN commented Aug 17, 2020

nmanovic commented Aug 17, 2020

nmanovic commented Aug 17, 2020

nmanovic commented Aug 17, 2020 •

edited

Loading

nmanovic commented Aug 18, 2020

nmanovic Aug 19, 2020

ActiveChooN Aug 20, 2020 •

edited

Loading

bsekachev commented Aug 21, 2020

Label color #2014

Label color #2014

Conversation

ActiveChooN commented Aug 11, 2020 • edited Loading

Motivation and context

How has this been tested?

Checklist

License

zhiltsov-max Aug 11, 2020

Choose a reason for hiding this comment

ActiveChooN Aug 11, 2020

Choose a reason for hiding this comment

zhiltsov-max Aug 11, 2020

Choose a reason for hiding this comment

coveralls commented Aug 11, 2020 • edited Loading

Pull Request Test Coverage Report for Build 7036

💛 - Coveralls

zhiltsov-max left a comment • edited Loading

Choose a reason for hiding this comment

bsekachev commented Aug 13, 2020

nmanovic commented Aug 17, 2020 • edited Loading

ActiveChooN commented Aug 17, 2020

nmanovic commented Aug 17, 2020

nmanovic commented Aug 17, 2020

nmanovic commented Aug 17, 2020 • edited Loading

nmanovic commented Aug 18, 2020

nmanovic Aug 19, 2020

Choose a reason for hiding this comment

ActiveChooN Aug 20, 2020 • edited Loading

Choose a reason for hiding this comment

bsekachev commented Aug 21, 2020

ActiveChooN commented Aug 11, 2020 •

edited

Loading

coveralls commented Aug 11, 2020 •

edited

Loading

zhiltsov-max left a comment •

edited

Loading

nmanovic commented Aug 17, 2020 •

edited

Loading

nmanovic commented Aug 17, 2020 •

edited

Loading

ActiveChooN Aug 20, 2020 •

edited

Loading