Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSoC2024] added entry to changelog.md for PR fixing accumulation of confusion matrix across jobs #7678

Merged

Conversation

Viditagarwal7479
Copy link
Contributor

Added entry to changelog.md for PR fixing accumulation of confusion matrix across jobs. As mentioned in #7604 this is a PR where the necessary changelog entry has been added.

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
    - [ ] I have updated the documentation accordingly
    - [ ] I have added tests to cover my changes
    - [ ] I have linked related issues (see GitHub docs)
    - [ ] I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

Copy link
Contributor

@zhiltsov-max zhiltsov-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a comment in the file, explaining how changelog updates should be done. Please follow this instruction.

@Viditagarwal7479
Copy link
Contributor Author

Thanks for pointing out. I just missed the scriv part and had only looked at the naming convention to be followed.

@zhiltsov-max zhiltsov-max merged commit e0732a3 into cvat-ai:develop Mar 26, 2024
13 checks passed
@bsekachev
Copy link
Member

bsekachev commented Mar 26, 2024

@zhiltsov-max

### Fixed <!-- pick one --> will not work. See CI in develop

changelog.d/20240326_150326_vidit.agarwal.eee20_changelog_confusion_matrix.md:1: unknown category: Fixed

@zhiltsov-max
Copy link
Contributor

zhiltsov-max commented Mar 26, 2024

It looks like we need a new PR check on CI. A separate one from build.

SpecLad pushed a commit that referenced this pull request Mar 26, 2024
Fixes #7678 as it breaks the CI.
@Viditagarwal7479 Viditagarwal7479 deleted the changelog_confusion_matrix branch March 26, 2024 17:26
g-kartik pushed a commit to g-kartik/cvat that referenced this pull request Mar 29, 2024
…confusion matrix across jobs (cvat-ai#7678)

Added entry to `changelog.md` for PR fixing accumulation of confusion
matrix across jobs. As mentioned in
cvat-ai#7604 this is a PR where the
necessary changelog entry has been added.

### Checklist
<!-- Go over all the following points, and put an `x` in all the boxes
that apply.
If an item isn't applicable for some reason, then ~~explicitly
strikethrough~~ the whole
line. If you don't do that, GitHub will show incorrect progress for the
pull request.
If you're unsure about any of these, don't hesitate to ask. We're here
to help! -->
- [x] I submit my changes into the `develop` branch
- [x] I have created a changelog fragment <!-- see top comment in
CHANGELOG.md -->
~- [ ] I have updated the documentation accordingly~
~- [ ] I have added tests to cover my changes~
~- [ ] I have linked related issues (see [GitHub docs](

https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword))~
~- [ ] I have increased versions of npm packages if it is necessary

([cvat-canvas](https://github.com/opencv/cvat/tree/develop/cvat-canvas#versioning),

[cvat-core](https://github.com/opencv/cvat/tree/develop/cvat-core#versioning),

[cvat-data](https://github.com/opencv/cvat/tree/develop/cvat-data#versioning)
and

[cvat-ui](https://github.com/opencv/cvat/tree/develop/cvat-ui#versioning))~

### License

- [x] I submit _my code changes_ under the same [MIT License](
https://github.com/opencv/cvat/blob/develop/LICENSE) that covers the
project.
  Feel free to contact the maintainers if that's a concern.
g-kartik pushed a commit to g-kartik/cvat that referenced this pull request Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants