Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update fast_line_detector.cpp #2912

Merged
merged 1 commit into from
Apr 8, 2021
Merged

Update fast_line_detector.cpp #2912

merged 1 commit into from
Apr 8, 2021

Conversation

sturkmen72
Copy link
Contributor

@sturkmen72 sturkmen72 commented Apr 6, 2021 •
edited
Loading

Documentation update and improvement on drawSegments()

  • [x I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@sturkmen72
Copy link
Contributor Author

i think #2716 should be merged in 3.4 branch before merge this ( ofcourse i will check the PR after #2716 backported )

@alalek alalek mentioned this pull request Apr 6, 2021
Merged
@sturkmen72
Copy link
Contributor Author

@alalek please review

alalek
alalek approved these changes Apr 8, 2021
View reviewed changes
Copy link
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you 👍

@opencv-pushbot opencv-pushbot merged commit 31c657e into opencv:3.4 Apr 8, 2021
@sturkmen72 sturkmen72 deleted the update_fast_line_detector branch April 8, 2021 09:34
This was referenced Apr 8, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alalek alalek alalek approved these changes

Assignees

@alalek alalek

Labels
category: documentation Documentation fix or update, does not affect code category: ximgproc feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sturkmen72 @alalek @opencv-pushbot