Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ceres::Manifolds instead of ceres::LocalParameterization. #3243

Merged
merged 4 commits into from
May 30, 2022
Merged

Use ceres::Manifolds instead of ceres::LocalParameterization. #3243

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
58cf500
Use ceres::Manifolds instead of ceres::LocalParameterization.
vrabaud Apr 29, 2022
880c12b
Fix typo.
vrabaud May 24, 2022
d55b9bc
Fix version check.
vrabaud May 25, 2022
9ca28c3
And more version fixes.
vrabaud May 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
22 changes: 22 additions & 0 deletions modules/sfm/src/libmv_light/libmv/simple_pipeline/bundle.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@

#include "ceres/ceres.h"
#include "ceres/rotation.h"
#include "ceres/version.h"
#include "libmv/base/vector.h"
#include "libmv/logging/logging.h"
#include "libmv/multiview/fundamental.h"
Expand Down Expand Up @@ -485,7 +486,11 @@ void EuclideanBundleCommonIntrinsics(
PackCamerasRotationAndTranslation(tracks, *reconstruction);

// Parameterization used to restrict camera motion for modal solvers.
#if CERES_VERSION_MAJOR >= 2 && CERES_VERSION_MINOR >= 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This check is not accurate as 3.0 version returns false.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, fixed.

ceres::SubsetManifold *constant_translation_manifold = NULL;
#else
ceres::SubsetParameterization *constant_translation_parameterization = NULL;
#endif
if (bundle_constraints & BUNDLE_NO_TRANSLATION) {
std::vector<int> constant_translation;

Expand All @@ -494,8 +499,13 @@ void EuclideanBundleCommonIntrinsics(
constant_translation.push_back(4);
constant_translation.push_back(5);

#if CERES_VERSION_MAJOR >= 2 && CERES_VERSION_MINOR >= 1
constant_translation_parameterization =
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean constant_translation_manifold?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed, thx. Fixed

new ceres::SubsetManifold(6, constant_translation);
#else
constant_translation_parameterization =
new ceres::SubsetParameterization(6, constant_translation);
#endif
}

// Add residual blocks to the problem.
Expand Down Expand Up @@ -538,8 +548,13 @@ void EuclideanBundleCommonIntrinsics(
}

if (bundle_constraints & BUNDLE_NO_TRANSLATION) {
#if CERES_VERSION_MAJOR >= 2 && CERES_VERSION_MINOR >= 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same issue with 3.0.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, sorry about that.

problem.SetParameterization(current_camera_R_t,
constant_translation_manifold);
#else
problem.SetParameterization(current_camera_R_t,
constant_translation_parameterization);
#endif
}

zero_weight_tracks_flags[marker.track] = false;
Expand Down Expand Up @@ -586,10 +601,17 @@ void EuclideanBundleCommonIntrinsics(
// Always set K3 constant, it's not used at the moment.
constant_intrinsics.push_back(OFFSET_K3);

#if CERES_VERSION_MAJOR >= 2 && CERES_VERSION_MINOR >= 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And the same.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

ceres::SubsetManifold *subset_manifold =
new ceres::SubsetManifold(OFFSET_MAX, constant_intrinsics);

problem.SetManifold(ceres_intrinsics, subset_manifold);
#else
ceres::SubsetParameterization *subset_parameterization =
new ceres::SubsetParameterization(OFFSET_MAX, constant_intrinsics);

problem.SetParameterization(ceres_intrinsics, subset_parameterization);
#endif
}

// Configure the solver.
Expand Down