Use ceres::Manifolds instead of ceres::LocalParameterization. #3243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latter is deprecated.
asenyaev
requested review from
asenyaev and
victor1234
and removed request for
victor1234 and
asenyaev
victor1234
suggested changes
May 18, 2022
| @@ -494,8 +499,13 @@ void EuclideanBundleCommonIntrinsics( | |||
| constant_translation.push_back(4); | |||
| constant_translation.push_back(5); | |||
|
|
|||
| #if CERES_VERSION_MAJOR >= 2 && CERES_VERSION_MINOR >= 1 | |||
| constant_translation_parameterization = | |||
There was a problem hiding this comment.
You mean constant_translation_manifold?
victor1234
approved these changes
May 24, 2022
alalek
reviewed
May 24, 2022
| @@ -485,7 +486,11 @@ void EuclideanBundleCommonIntrinsics( | |||
| PackCamerasRotationAndTranslation(tracks, *reconstruction); | |||
|
|
|||
| // Parameterization used to restrict camera motion for modal solvers. | |||
| #if CERES_VERSION_MAJOR >= 2 && CERES_VERSION_MINOR >= 1 | |||
There was a problem hiding this comment.
This check is not accurate as 3.0 version returns false.
asmorkalov
reviewed
May 27, 2022
| @@ -538,8 +548,13 @@ void EuclideanBundleCommonIntrinsics( | |||
| } | |||
|
|
|||
| if (bundle_constraints & BUNDLE_NO_TRANSLATION) { | |||
| #if CERES_VERSION_MAJOR >= 2 && CERES_VERSION_MINOR >= 1 | |||
There was a problem hiding this comment.
The same issue with 3.0.
There was a problem hiding this comment.
Done, sorry about that.
| @@ -586,10 +601,17 @@ void EuclideanBundleCommonIntrinsics( | |||
| // Always set K3 constant, it's not used at the moment. | |||
| constant_intrinsics.push_back(OFFSET_K3); | |||
|
|
|||
| #if CERES_VERSION_MAJOR >= 2 && CERES_VERSION_MINOR >= 1 | |||
This was referenced Jun 4, 2022
Merged
|
error: cannot initialize a parameter of type 'ceres::LocalParameterization *' with an lvalue of type 'ceres::SubsetManifold *' |
hakaboom
pushed a commit
to hakaboom/opencv_contrib
that referenced
this pull request
Jul 1, 2022
* Use ceres::Manifolds instead of ceres::LocalParameterization. The latter is deprecated. * Fix typo. * Fix version check. * And more version fixes.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use ceres::Manifolds instead of ceres::LocalParameterization.
The latter is deprecated.
This fixes #3218
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request