Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated code to handle maximum query length limitation in darktrace. #1259

Conversation

thangaraj-ramesh
Copy link
Contributor

Updated code to handle maximum query length limitation in darktrace by splitting the query based on the maximum query limit. #1205

Updated code to handle maximum query length limitation in darktrace by splitting the query based on the maximum query limit.
@codecov
Copy link

codecov bot commented Dec 28, 2022

Codecov Report

Base: 85.35% // Head: 85.35% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (4d9f4e8) compared to base (214babd).
Patch coverage: 84.32% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1259      +/-   ##
===========================================
- Coverage    85.35%   85.35%   -0.01%     
===========================================
  Files          558      558              
  Lines        41570    41753     +183     
===========================================
+ Hits         35482    35637     +155     
- Misses        6088     6116      +28     
Impacted Files Coverage Δ
...es/darktrace/stix_translation/query_constructor.py 87.43% <82.31%> (-3.61%) ⬇️
...t/stix_translation/test_darktrace_stix_to_query.py 98.95% <100.00%> (+0.08%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@delliott90 delliott90 merged commit 88a2af6 into opencybersecurityalliance:develop Jan 10, 2023
delliott90 pushed a commit that referenced this pull request Jan 24, 2023
…1259)

* Updated code to handle maximum query length limitation in darktrace.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants