Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elastic_ecs: fix STIX 2.1 results translation #1306

Merged
merged 1 commit into from
Feb 1, 2023

Conversation

pcoccoli
Copy link
Collaborator

Remove unnecessary result processing that raised the exception for STIX 2.1.

Fixes #1304

@pcoccoli pcoccoli self-assigned this Jan 30, 2023
@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Base: 85.35% // Head: 85.36% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (aa2f9a0) compared to base (a9e5b43).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1306   +/-   ##
========================================
  Coverage    85.35%   85.36%           
========================================
  Files          569      569           
  Lines        42557    42572   +15     
========================================
+ Hits         36323    36340   +17     
+ Misses        6234     6232    -2     
Impacted Files Coverage Δ
...elastic_ecs/stix_translation/results_translator.py 100.00% <ø> (+4.76%) ⬆️
.../stix_translation/test_elastic_ecs_json_to_stix.py 100.00% <100.00%> (ø)
stix_shifter_utils/utils/helpers.py 62.50% <0.00%> (+2.08%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pcoccoli pcoccoli removed their assignment Jan 31, 2023
@delliott90 delliott90 merged commit c2a3561 into opencybersecurityalliance:develop Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

elastic_ecs module raises spurious exception for STIX 2.1 results
2 participants