Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReaQta Use TTP Custom Object #1473

Merged
merged 11 commits into from
May 31, 2023
Merged

ReaQta Use TTP Custom Object #1473

merged 11 commits into from
May 31, 2023

Conversation

JingqiuDu
Copy link
Contributor

No description provided.

@JingqiuDu JingqiuDu requested a review from mdazam1942 May 8, 2023 19:18
@JingqiuDu JingqiuDu self-assigned this May 8, 2023
@JingqiuDu JingqiuDu requested a review from delliott90 May 10, 2023 16:23
@@ -109,7 +110,8 @@
"network_ref.src_ref.value": ["ip"],
"parent_process_ref.pid": ["service.ppid"],
"process_ref.pid": ["wmi.clientPid"],
"user_ref.user_id": []
"user_ref.user_id": [],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this mapping to an empty list of fields?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what it was, I just delete the comma at the end to make it valid Json.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should just be removed, it shouldn't be there because it's not actually mapping to anything.

@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (163bf05) 85.18% compared to head (d392491) 85.18%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1473      +/-   ##
===========================================
- Coverage    85.18%   85.18%   -0.01%     
===========================================
  Files          679      679              
  Lines        53153    53149       -4     
===========================================
- Hits         45279    45275       -4     
  Misses        7874     7874              
Impacted Files Coverage Δ
.../test/stix_translation/test_reaqta_json_to_stix.py 99.49% <100.00%> (-0.01%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JingqiuDu JingqiuDu force-pushed the ReaQtaUseTTPCustomObject branch 2 times, most recently from 92134e6 to e99e779 Compare May 15, 2023 21:27
@JingqiuDu JingqiuDu requested a review from delliott90 May 16, 2023 13:45
@@ -1824,8 +1824,8 @@
"object": "x-reaqta"
},
"tactics": {
"key": "x-reaqta-event.tactics",
"object": "x-reaqta"
"key": "x-ibm-finding.ttp_tagging_refs",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to also create an x-ibm-ttp-tagging object when the tactics and technique fields are in the native results. This is the object that the x-ibm-finding.ttp_tagging_refs will reference. For an example of referencing, take a look at how the x-oca-asset.ip_refs references the src_ip in this same file.

"tactics": [
{
"key": "x-ibm-finding.ttp_tagging_refs",
"object": "x-ibm-finding"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a reference key, you also need to include a "references" property that maps to the ttp object. In this case it would be "references": ["x-ibm-ttp-tagging"]

"tactics": [
{
"key": "x-ibm-finding.ttp_tagging_refs",
"object": "x-ibm-finding"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing references property

"technique": [
{
"key": "x-ibm-finding.ttp_tagging_refs",
"object": "x-ibm-finding"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing references property

@delliott90 delliott90 merged commit 1d8ca73 into develop May 31, 2023
9 checks passed
@delliott90 delliott90 deleted the ReaQtaUseTTPCustomObject branch May 31, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants