Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix variable assignment error with ECS event.start/end #1556

Merged

Conversation

Technici4n
Copy link
Contributor

Quite straightforward, especially if you look at the surrounding code.

@CLAassistant
Copy link

CLAassistant commented Aug 14, 2023

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (2ca0017) 85.75% compared to head (d106a63) 85.75%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1556   +/-   ##
========================================
  Coverage    85.75%   85.75%           
========================================
  Files          551      551           
  Lines        46334    46334           
========================================
  Hits         39734    39734           
  Misses        6600     6600           
Files Changed Coverage Δ
.../elastic_ecs/stix_translation/query_constructor.py 95.41% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@delliott90 delliott90 merged commit 634f037 into opencybersecurityalliance:develop Aug 15, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants