add email-message translation to ecs #1621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Partially resolve #1518 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1621 +/- ##
========================================
Coverage 86.00% 86.01%
========================================
Files 572 572
Lines 48676 48710 +34
========================================
+ Hits 41862 41896 +34
Misses 6814 6814 ☔ View full report in Codecov by Sentry. |
mdazam1942
reviewed
Nov 29, 2023
| observed_data = translation_objects[1] | ||
| stix_objects = observed_data.get("objects") | ||
| assert len(stix_objects) == 8 |
There was a problem hiding this comment.
i would put more specific test to verify if the objects are created correctly.
There was a problem hiding this comment.
More specific tests added.
mdazam1942
approved these changes
Nov 29, 2023
mdazam1942
merged commit 30ba487
into
opencybersecurityalliance:develop
5 checks passed
DerekRushton
pushed a commit
that referenced
this pull request
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.