CrowdStrike Logscale UDI Connector #1631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added UDI connector for CrowdStrike Logscale data source
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1631 +/- ##
===========================================
+ Coverage 86.26% 86.52% +0.25%
===========================================
Files 586 600 +14
Lines 50040 51314 +1274
===========================================
+ Hits 43166 44397 +1231
- Misses 6874 6917 +43 ☔ View full report in Codecov by Sentry. |
Updated the code to fix python 3.8 test failure
Added a boolean parameter - combined_observation to handle different qualifiers to handle filter functions.
mdazam1942
reviewed
Jan 22, 2024
...hifter_modules/crowdstrike_logscale/stix_translation/json/crowdstrike_edr_from_stix_map.json
Outdated
Show resolved
Hide resolved
1. Updated the dialect name crowdstrik_edr to crowdstrikeedr in mapping files. 2. Updated unit test case files, config file, read me, entry point files with respect to change in dialect name.
DerekRushton
reviewed
Feb 6, 2024
stix_shifter_modules/crowdstrike_logscale/stix_translation/transformers.py
Show resolved
Hide resolved
stix_shifter_modules/crowdstrike_logscale/stix_translation/transformers.py
Outdated
Show resolved
Hide resolved
stix_shifter_modules/crowdstrike_logscale/configuration/config.json
Outdated
Show resolved
Hide resolved
stix_shifter_modules/crowdstrike_logscale/configuration/config.json
Outdated
Show resolved
Hide resolved
stix_shifter_modules/crowdstrike_logscale/configuration/lang_en.json
Outdated
Show resolved
Hide resolved
stix_shifter_modules/crowdstrike_logscale/stix_translation/json/crowdstrikeedr_to_stix_map.json
Show resolved
Hide resolved
Modified the transformer of MAC- address and updated the config files with respect to repository. Changes corresponding to config has been done in transmit files and read-me files. Updated except class to reuse the exception_response function in connector.py file
…MS-Hcl/stix-shifter into crowdstrike_logscale_v1
stix_shifter_modules/crowdstrike_logscale/configuration/lang_en.json
Outdated
Show resolved
Hide resolved
updated transformer and readme file based on review comments
Updated the error codes in read me and added back the connector extension details.
mdazam1942
reviewed
Mar 11, 2024
stix_shifter_modules/crowdstrike_logscale/stix_transmission/connector.py
Outdated
Show resolved
Hide resolved
mdazam1942
reviewed
Mar 11, 2024
stix_shifter_modules/crowdstrike_logscale/stix_transmission/connector.py
Outdated
Show resolved
Hide resolved
added connector name in logger error
Updated the connector with Pagination logic and updated unit test cases, readme files.
DerekRushton
reviewed
Apr 8, 2024
stix_shifter_modules/crowdstrike_logscale/stix_translation/transformers.py
Show resolved
Hide resolved
stix_shifter_modules/crowdstrike_logscale/stix_translation/query_constructor.py
Outdated
Show resolved
Hide resolved
stix_shifter_modules/crowdstrike_logscale/stix_transmission/api_client.py
Outdated
Show resolved
Hide resolved
stix_shifter_modules/crowdstrike_logscale/stix_transmission/query_connector.py
Show resolved
Hide resolved
stix_shifter_modules/crowdstrike_logscale/stix_transmission/delete_connector.py
Outdated
Show resolved
Hide resolved
stix_shifter_modules/crowdstrike_logscale/stix_transmission/results_connector.py
Outdated
Show resolved
Hide resolved
stix_shifter_modules/crowdstrike_logscale/stix_transmission/results_connector.py
Show resolved
Hide resolved
stix_shifter_modules/crowdstrike_logscale/stix_transmission/api_client.py
Show resolved
Hide resolved
stix_shifter_modules/crowdstrike_logscale/stix_transmission/query_connector.py
Show resolved
Hide resolved
Updated the code and unit test cases accordingly
updated the code and unit test cases with pagination
stix_shifter_modules/crowdstrike_logscale/stix_transmission/results_connector.py
Show resolved
Hide resolved
stix_shifter_modules/crowdstrike_logscale/configuration/lang_en.json
Outdated
Show resolved
Hide resolved
DerekRushton
approved these changes
Apr 24, 2024
DerekRushton
merged commit af474b6
into
opencybersecurityalliance:develop
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added UDI connector module for CrowdStrike Logscale data source.