Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amazon athena resolve column not found exception #1673

Merged

Conversation

DerekRushton
Copy link
Collaborator

  1. Fixes an issue where the column list included columns from unselected databases.
  2. Added additional logic to handle column not found exception.
  3. Resolved an issue where the SQL keyword "group" was causing issue with some mappings in from_stix for oscf.

Signed-off-by: DerekRushton <derek.rushton1@ibm.com>
Signed-off-by: DerekRushton <derek.rushton1@ibm.com>
Signed-off-by: DerekRushton <derek.rushton1@ibm.com>
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 96.35417% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 86.30%. Comparing base (3bae101) to head (58df245).

❗ Current head 58df245 differs from pull request most recent head e3a7498. Consider uploading reports for the commit e3a7498 to get more accurate results

Files Patch % Lines
...es/aws_athena/stix_transmission/query_connector.py 80.00% 6 Missing ⚠️
...s/aws_athena/stix_transmission/status_connector.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1673      +/-   ##
===========================================
+ Coverage    86.26%   86.30%   +0.04%     
===========================================
  Files          586      588       +2     
  Lines        50040    50221     +181     
===========================================
+ Hits         43166    43345     +179     
- Misses        6874     6876       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdazam1942 mdazam1942 merged commit 84f074a into develop Apr 9, 2024
7 of 8 checks passed
@mdazam1942 mdazam1942 deleted the Amazon_Athena_Resolve_Column_Not_Found_Exception branch April 9, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants