Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add feature to disable pagination and simplify API #1676

Conversation

subbyte
Copy link
Member

@subbyte subbyte commented Apr 9, 2024

Elasticsearch could encounter a performance issue with sort in the query (API call). However, sort is required for pagination. So we add a feature to disable pagination, thus does not need sort and resolve an Elasticsearch 504 error when the data is too large for the Elasticsearch instance to search.

@subbyte subbyte marked this pull request as draft April 9, 2024 18:39
@subbyte subbyte marked this pull request as ready for review April 9, 2024 18:49
@subbyte subbyte requested a review from mdazam1942 April 19, 2024 20:07
@mdazam1942 mdazam1942 merged commit fd30e29 into opencybersecurityalliance:develop May 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants