Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible duplicate $SUBDIRS definition in bes/modules/Makefile.am #104

Closed
lewismc opened this issue Feb 20, 2018 · 2 comments
Closed

Possible duplicate $SUBDIRS definition in bes/modules/Makefile.am #104

lewismc opened this issue Feb 20, 2018 · 2 comments

Comments

@lewismc
Copy link
Contributor

lewismc commented Feb 20, 2018

Hi Folks,
Our Capstone team (@rrimer07, @hemphilc and @RiverHendriksen) have encountered a duplicate definitions warning whilst attempting to configure and install bes from source.
Having discussed this, we think it relates to the duplicate definition of SUBDIRS in bes/modules/Makefile.am.
Can someone scope this out and let us know? If you can reproduce the warning, let us know and we will submit a PR. Thanks

@jgallagher59701
Copy link
Member

jgallagher59701 commented Feb 20, 2018 via email

@lewismc lewismc changed the title Possibly duplicate $SUBDIRS definition in bes/modules/Makefile.am Possible duplicate $SUBDIRS definition in bes/modules/Makefile.am Feb 20, 2018
@lewismc
Copy link
Contributor Author

lewismc commented Feb 21, 2018

Thank you folks

@lewismc lewismc closed this as completed Feb 21, 2018
jgallagher59701 pushed a commit that referenced this issue Jan 7, 2022
This change implements move ctor and assign support for xml_document.

All node handles remain valid after the move and point to the new document; the only exception is the document node itself (that remains unmoved).

Move is O(document size) in theory because it needs to relocate immediate document children (there is just one in conformant documents) and all memory pages; in practice the memory pages only need the header adjusted, which is ~0.1% of the actual data size.

Move requires no allocations in general, except when using compact mode where some moves need to grow the hash table which can fail (throw).

Fixes #104
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants