Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataset add `--auto-match` option is redundant #448

Closed
Kirill888 opened this issue May 16, 2018 · 0 comments

Comments

@Kirill888
Copy link
Contributor

commented May 16, 2018

  • It's enabled by default even if not supplied
  • It suggests that without it there is a manual product association, but no such thing exists
  • Manual product association is not even possible due to handling of lineage datasets

dataset add always performs matching of dataset definition document to a set of product definitions. A set of products being matched against is either

  • Full set of products in the database (default behaviour)
  • Subset of products from the database (product to match against are specified with multiple --dtype options)
  • Subset of products from the database with some modifications loaded from a file with --match-rules option (I suggest we get rid of this one)

Because dataset add supports adding datasets found in the lineage subdocument to the database there is no way to supply "manual" product<->dataset relation in a general case.

Kirill888 added a commit that referenced this issue May 16, 2018

@Kirill888 Kirill888 closed this May 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.