Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add optional crc metadata overlay #58

Merged

Conversation

pvaneck
Copy link

@pvaneck pvaneck commented Sep 4, 2020

This overlay still seems to be needed to get around a metadata db issue when using CRC. Without this overlay, I am getting issues with the metadata-db pod unable to stand up mysql with mkdir: cannot create directory '/var/lib/mysql': Permission denied.

The openshift kfdef file currently references this optional overlay (https://github.com/opendatahub-io/manifests/blob/v1.0-branch-openshift/kfdef/kfctl_openshift.yaml#L121), and this overlay exists in the v0.7-branch-openshift branch, so it was probably just forgotten when the new branch was created.

This overlay is needed to get around a metadata db issue when using CRC.
@openshift-ci-robot
Copy link

Hi @pvaneck. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nakfour
Copy link

nakfour commented Sep 10, 2020

thanks @pvaneck, @LaVLaS working to re-creating the issue

@LaVLaS LaVLaS self-requested a review September 15, 2020 03:04
@LaVLaS
Copy link

LaVLaS commented Sep 15, 2020

/lgtm

Thank you for restoring this overlay

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: LaVLaS, pvaneck
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@LaVLaS LaVLaS merged commit 57a94b2 into opendatahub-io:v1.0-branch-openshift Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants