Solves multiple group storing issue. #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbeorse
approved these changes
Jun 15, 2019
linl33
reviewed
Jun 17, 2019
| @@ -364,10 +363,11 @@ public void onSuccess(PendingDynamicLinkData pendingDynamicLinkData) { | |||
| public void onDataChange(@NonNull DataSnapshot dataSnapshot) { | |||
| Group group = new Group((String)dataSnapshot.child("id").getValue(),(String)dataSnapshot.child("name").getValue(),0); | |||
| new SubscribeNotificationGroup(MainActivity.this,group.getId(),getActiveUser()).execute(); | |||
| DatabaseReference databaseReference = FirebaseDatabase.getInstance().getReference().child("clients").child(getActiveUser()).child("groups"); | |||
| DatabaseReference databaseReference = FirebaseDatabase.getInstance().getReference().child("clients").child(getActiveUser()).child("groups").push(); | |||
| databaseReference.child("id").setValue(group.getId()); | |||
| databaseReference.child("name").setValue(group.getName()); | |||
There was a problem hiding this comment.
The changes look good but why is the Firebase database being modified here?
There was a problem hiding this comment.
Actually before, on subscribing to a new group, it was overwriting the previous group data on firebase. So, on syncing with the server it fetches only one group from the firebase database. To resolve this, each group data is now stored under a random key generated by push()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #27
