Adds Firebase Database URL field in Configure Section. #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Firebase Database URL field in Configure Section.
linl33
requested changes
Jun 2, 2019
| @@ -54,7 +54,21 @@ | |||
| <children> | |||
| <TextField fx:id="webAPIKeyField" prefHeight="31.0" prefWidth="400.0" /> | |||
| </children> | |||
| </HBox> <Label text="Dynamic Link Domain"> | |||
| </HBox> | |||
| <Label text="Database URL"> | |||
There was a problem hiding this comment.
Database URL could mean a number of things in this context. Pick a different label, maybe Firebase Realtime Database URL or Firebase Database URL.
src/main/java/Data/Data.java
Outdated
| @@ -30,6 +31,7 @@ public Data(){ | |||
| setDYNAMIC_LINK_DOMAIN((String) mainObject.getString("dynamicLinkDomain")); | |||
| setANDROID_APP_PACKAGE_NAME((String) mainObject.getString("packageName")); | |||
| setSYNC_CLIENT_URL((String) mainObject.getString("syncClientURL")); | |||
| setDATABASE_URL((String) mainObject.getString("databaseURL")); | |||
linl33
reviewed
Jun 2, 2019
src/main/java/Data/Data.java
Outdated
| @@ -142,4 +146,12 @@ public String toString() { | |||
| ", SYNC_CLIENT_URL='" + SYNC_CLIENT_URL + '\'' + | |||
| '}'; | |||
| } | |||
|
|
|||
| public String getDATABASE_URL() { | |||
There was a problem hiding this comment.
Please follow the convention of this class and move these getter/setter up where the other getters and setters are.
|
@linl33 please review new changes. |
linl33
reviewed
Jun 2, 2019
src/main/java/Data/Data.java
Outdated
| @Override | ||
| public String toString() { | ||
| return "Data{" + | ||
| "SUPERVISOR_ID='" + SUPERVISOR_ID + '\'' + | ||
| ", WEB_API_KEY='" + WEB_API_KEY + '\'' + | ||
| ", DATABASE_URL='" + DATABASE_URL + '\'' + | ||
| ", DATABASE_URL='" + FIREBASE_DATABASE_URL + '\'' + |
There was a problem hiding this comment.
", DATABASE_URL='"
This string here should be changed as well.
jbeorse
approved these changes
Jun 3, 2019
linl33
approved these changes
Jun 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21