DevShop playbooks do not automatically infer the variables needed to set itself up. #652
Labels
Comments
jonpugh
pushed a commit
that referenced
this issue
Dec 17, 2020
DRASTICALLY IMPROVES the ability for users to contribute to DevShop because they can use forks locally and tests run properly! Huge thanks to @matthandus for helping me step through every bit of the process to identify these issues. * Use the right code, git remote and reference in forked pull requests. Follow up issue: #652 * Output custom CI vars to vars.ci.yml file, and set using ANSIBLE_PLAYBOOK_COMMAND_OPTIONS so that ANSIBLE_EXTRA_VARS can be used for matrix variations. * Fix Robofile to be aware of the git remote and reference by implementing `GitRepositoryAwareTrait` to automatically set `devshop_version` and `devshop_cli_repo` to those. * Create a list of repos that developers might need write access to and offer to change http git urls to SSH, (using the detected owner/name of the current working copy.) * Improve robo up terminal output to clearly state version and remotes of main and sub projects in the first few lines. Follow up issue: #653 * Default `devshop_control_git_remote` to the `devshop_cli_repo` ansible variable. * Confirm versions and releases in `devmaster:install` command by checking version against the `git_remote` specified. * Add an "open" wrapper to DevShop GitRepository class so the docblock returns the extension class. * Add methods to GitRepository class for getCurrentRemoteName, getCurrentRemoteUrl, isCurrentRemoteHttp. Co-authored-by: Matt Hand <34258655+matthandus@users.noreply.github.com> #651
devshopbot
pushed a commit
to opendevshop/ansible-role-devmaster
that referenced
this issue
Dec 17, 2020
DRASTICALLY IMPROVES the ability for users to contribute to DevShop because they can use forks locally and tests run properly! Huge thanks to @matthandus for helping me step through every bit of the process to identify these issues. * Use the right code, git remote and reference in forked pull requests. Follow up issue: opendevshop/devshop#652 * Output custom CI vars to vars.ci.yml file, and set using ANSIBLE_PLAYBOOK_COMMAND_OPTIONS so that ANSIBLE_EXTRA_VARS can be used for matrix variations. * Fix Robofile to be aware of the git remote and reference by implementing `GitRepositoryAwareTrait` to automatically set `devshop_version` and `devshop_cli_repo` to those. * Create a list of repos that developers might need write access to and offer to change http git urls to SSH, (using the detected owner/name of the current working copy.) * Improve robo up terminal output to clearly state version and remotes of main and sub projects in the first few lines. Follow up issue: opendevshop/devshop#653 * Default `devshop_control_git_remote` to the `devshop_cli_repo` ansible variable. * Confirm versions and releases in `devmaster:install` command by checking version against the `git_remote` specified. * Add an "open" wrapper to DevShop GitRepository class so the docblock returns the extension class. * Add methods to GitRepository class for getCurrentRemoteName, getCurrentRemoteUrl, isCurrentRemoteHttp. Co-authored-by: Matt Hand <34258655+matthandus@users.noreply.github.com> opendevshop/devshop#651
devshopbot
pushed a commit
to devshop-packages/composer-common
that referenced
this issue
Dec 17, 2020
DRASTICALLY IMPROVES the ability for users to contribute to DevShop because they can use forks locally and tests run properly! Huge thanks to @matthandus for helping me step through every bit of the process to identify these issues. * Use the right code, git remote and reference in forked pull requests. Follow up issue: opendevshop/devshop#652 * Output custom CI vars to vars.ci.yml file, and set using ANSIBLE_PLAYBOOK_COMMAND_OPTIONS so that ANSIBLE_EXTRA_VARS can be used for matrix variations. * Fix Robofile to be aware of the git remote and reference by implementing `GitRepositoryAwareTrait` to automatically set `devshop_version` and `devshop_cli_repo` to those. * Create a list of repos that developers might need write access to and offer to change http git urls to SSH, (using the detected owner/name of the current working copy.) * Improve robo up terminal output to clearly state version and remotes of main and sub projects in the first few lines. Follow up issue: opendevshop/devshop#653 * Default `devshop_control_git_remote` to the `devshop_cli_repo` ansible variable. * Confirm versions and releases in `devmaster:install` command by checking version against the `git_remote` specified. * Add an "open" wrapper to DevShop GitRepository class so the docblock returns the extension class. * Add methods to GitRepository class for getCurrentRemoteName, getCurrentRemoteUrl, isCurrentRemoteHttp. Co-authored-by: Matt Hand <34258655+matthandus@users.noreply.github.com> opendevshop/devshop#651
jonpugh
added a commit
that referenced
this issue
Dec 17, 2020
DRASTICALLY IMPROVES the ability for users to contribute to DevShop because they can use forks locally and tests run properly! Huge thanks to @matthandus for helping me step through every bit of the process to identify these issues. * Use the right code, git remote and reference in forked pull requests. Follow up issue: #652 * Output custom CI vars to vars.ci.yml file, and set using ANSIBLE_PLAYBOOK_COMMAND_OPTIONS so that ANSIBLE_EXTRA_VARS can be used for matrix variations. * Fix Robofile to be aware of the git remote and reference by implementing `GitRepositoryAwareTrait` to automatically set `devshop_version` and `devshop_cli_repo` to those. * Create a list of repos that developers might need write access to and offer to change http git urls to SSH, (using the detected owner/name of the current working copy.) * Improve robo up terminal output to clearly state version and remotes of main and sub projects in the first few lines. Follow up issue: #653 * Default `devshop_control_git_remote` to the `devshop_cli_repo` ansible variable. * Confirm versions and releases in `devmaster:install` command by checking version against the `git_remote` specified. * Add an "open" wrapper to DevShop GitRepository class so the docblock returns the extension class. * Add methods to GitRepository class for getCurrentRemoteName, getCurrentRemoteUrl, isCurrentRemoteHttp. #651 Co-authored-by: Jon Pugh <jon@thinkdrop.net>
|
This issue has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution! |
|
This issue has been closed due to inactivity. If you feel this is in error, please reopen the issue or file a new issue with the relevant details. |
|
This issue is no longer marked for closure. |
|
This issue has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution! |
|
This issue has been closed due to inactivity. If you feel this is in error, please reopen the issue or file a new issue with the relevant details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
DevShop playbooks do not automatically infer the variables needed to set itself up.
Meaning: A clone of devshop source using a different remote and git branch will still "install" the default devshop source repo and version.
When running in CI, they are set via scripts.
When running from robo, they are set by the Robofile.
If the variables
devshop_versionet al are not setAnd the playbooks are being run from the git repository
Then the playbook should set the value of
devshop_versionanddevshop_cli_repofrom the current git remote and reference.Right?
The text was updated successfully, but these errors were encountered: