Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be able to configure the docker directory to use when building #181

Closed
oalyman opened this issue Jan 14, 2020 · 2 comments · Fixed by #188
Closed

Be able to configure the docker directory to use when building #181

oalyman opened this issue Jan 14, 2020 · 2 comments · Fixed by #188
Assignees
Labels
enhancement New feature or request

Comments

@oalyman
Copy link
Contributor

oalyman commented Jan 14, 2020

Is your feature request related to a problem? Please describe.
Currently the --from-dir for oc start-build in stageStartOpenshiftBuild.groovy is fixed to docker.
Some build tools already generate a docker directory including a Dockerfile.
Currently, I need to copy stuff over to the docker directory.
Additionally, If I choose to use a PV for my build I would need to take care of cleaning up the docker directory again.
Being able to set the docker directory to use one would have more flexibility and might reduce copy/cleanup logic.

Describe the solution you'd like
It would be nice if I could configure the directory used for --from-dir.

Describe alternatives you've considered
none

Additional context
none

@oalyman oalyman added the enhancement New feature or request label Jan 14, 2020
@michaelsauter
Copy link
Member

Agree, might be good not to hardcode. On the other hand, it is kind of nice to have a "ODS way of doing things", so that when I am new to a repo which is deployed using ODS, I know where to look. docker folder will be where my Dockerfile is.

@oalyman
Copy link
Contributor Author

oalyman commented Jan 14, 2020

One doesn't exclude the other.
I just want to copy the static handwritten Dockerfile from the docker folder to the configured docker folder of my build tool which contains generated files / directories for the docker image.
This way I benefit from automatic cleanup when doing a clean build.

@oalyman oalyman self-assigned this Jan 21, 2020
michaelsauter pushed a commit to BIX-Digital/ods-jenkins-shared-library that referenced this issue Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants