-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make docker dir configurable #188
Make docker dir configurable #188
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool 👍
@@ -436,6 +440,10 @@ class OdsContext implements Context { | |||
config.displayNameUpdateEnabled = displayNameUpdateEnabled | |||
} | |||
|
|||
String getDockerDir() { | |||
return config.dockerDir | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you'll need to add this to the Context
interface too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
docs/modules/ROOT/pages/index.adoc
Outdated
@@ -290,6 +290,9 @@ When you write stages, you have access to both global variables (defined without | |||
|
|||
| ciSkip | |||
| Whether the build should be skipped, based on the Git commit message. | |||
|
|||
| dockerDir | |||
| The docker directory to use when building the image in openshift |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this could be "The Docker context directory to use when building the image in OpenShift. Defaults to docker
."?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
Resolves #181