Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ods-pipeline should have 2 more stages (start / finish) #201

Closed
clemensutschig opened this issue Mar 17, 2020 · 3 comments
Closed

ods-pipeline should have 2 more stages (start / finish) #201

clemensutschig opened this issue Mar 17, 2020 · 3 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@clemensutschig
Copy link
Member

clemensutschig commented Mar 17, 2020

Describe the solution you'd like
In order to verify odsPipeline did run w/o looking into the logs - we should add 3 more stages into the pipeline

namely

  1. odsPipeline start (https://github.com/opendevstack/ods-jenkins-shared-library/blob/master/vars/odsPipeline.groovy#L5)
  2. (rename) Prepare ods context (https://github.com/opendevstack/ods-jenkins-shared-library/blob/master/src/org/ods/OdsPipeline.groovy#L31)
  3. odsPipeline finished (https://github.com/opendevstack/ods-jenkins-shared-library/blob/master/src/org/ods/OdsPipeline.groovy#L87-L90)
  4. odsPipeline error (https://github.com/opendevstack/ods-jenkins-shared-library/blob/master/src/org/ods/OdsPipeline.groovy#L93-L112)
@clemensutschig clemensutschig added this to To Do in OpenDevStack 3.0 via automation Mar 17, 2020
@clemensutschig clemensutschig added enhancement New feature or request good first issue Good for newcomers labels Mar 17, 2020
@renedupont
Copy link
Member

I see a minor issue @clemensutschig
If we want to echo a stage start info with componentId and gitBranch like for the other stages, we don't have the gitBranch info for the 'odsPipeline start' stage at that time since it gets determined later in the 'Prepare' stage.

@clemensutschig
Copy link
Member Author

@renedupont - NOT needed ... the stages should be named exactly as described above .. e.g. "odsPipeline start"

renedupont added a commit to BIX-Digital/ods-jenkins-shared-library that referenced this issue Mar 18, 2020
…oovy

- moved instancing of git and openshift services after context.assemble in prepare stage
- moved a couple of methods into the respective git or openshift service
- added stages (see opendevstack#201)
- minor refactoring
@renedupont
Copy link
Member

After further discussion with @clemensutschig we decided to leave the first stage 'odsPipeline start' out and rename the 'Prepare' to 'odsPipeline start' instead of 'Prepare ods context'. The finished and error stages were implemented as desired.

start stage: https://github.com/opendevstack/ods-jenkins-shared-library/pull/202/files#diff-9b926a359deb3f339e040516225f076eR36
finish: https://github.com/opendevstack/ods-jenkins-shared-library/pull/202/files#diff-9b926a359deb3f339e040516225f076eR99
error: https://github.com/opendevstack/ods-jenkins-shared-library/pull/202/files#diff-9b926a359deb3f339e040516225f076eR107

OpenDevStack 3.0 automation moved this from To Do to Done Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
No open projects
Development

No branches or pull requests

2 participants