Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to configure imageStreamTag instead of image #233

Closed
michaelsauter opened this issue Apr 6, 2020 · 0 comments · Fixed by #235
Closed

Allow to configure imageStreamTag instead of image #233

michaelsauter opened this issue Apr 6, 2020 · 0 comments · Fixed by #235
Assignees
@michaelsauter
Labels
enhancement New feature or request
Projects
OpenDevStack 3.0

Comments

@michaelsauter
Copy link
Member

Most likely, the Jenkins agent node image should be pulled from the registry within OpenShift. However, users always have to configure the docker registry in the Jenkinsfile, which is a lot of boilerplate when it is not needed most of the time.

To simplify, we can provide a new config option imageStreamTag, which allows users to specify foo/bar:baz (project/imageStream:tag), and the registry host is auto-filled by the shared library.
@michaelsauter michaelsauter added the enhancement New feature or request label Apr 6, 2020
@michaelsauter michaelsauter self-assigned this Apr 6, 2020
@michaelsauter michaelsauter added this to To Do in OpenDevStack 3.0 via automation Apr 6, 2020
michaelsauter added a commit to BIX-Digital/ods-jenkins-shared-library that referenced this issue Apr 7, 2020
@michaelsauter
Allow to configure "imageStreamTag" instead of "image"
a57b5c9 
This reduces boilerplate in the Jenkinsfile.

Closes opendevstack#233.
@michaelsauter michaelsauter mentioned this issue Apr 7, 2020
Merged
OpenDevStack 3.0 automation moved this from To Do to Done Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelsauter michaelsauter

Labels
enhancement New feature or request
Projects
No open projects
OpenDevStack 3.0
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow to configure "imageStreamTag" instead of "image" BIX-Digital/ods-jenkins-shared-library
1 participant
@michaelsauter