Improve messages in Helm deployment issues with custom chartDir option #1044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will bail out if the repository is ambigious about the deployment descriptor. It will fail if: * there is no deployment descriptor * there is more than one deployment descriptor For a successfull release to happen, developers are required to "clean" their repository of unrelated deployment desciptors that could interfere with the current version.
|
Does this look acceptable? in the Jenkins log:
and in JIRA:
|
…m-chartdir-option # Conflicts: # CHANGELOG.md
|
@jafarre-bi, @jorge-romero, @hrcornejo -- can you review this? |
…m-chartdir-option # Conflicts: # CHANGELOG.md
|
@jafarre-bi, @jorge-romero, @hrcornejo -- can you review this? |
…m-chartdir-option # Conflicts: # CHANGELOG.md
jafarre-bi
previously requested changes
Feb 27, 2024
resources/org/ods/component/RolloutOpenShiftDeploymentStage.deprecate-tailor.GString.txt
Show resolved
Hide resolved
resources/org/ods/component/RolloutOpenShiftDeploymentStage.deprecate-tailor.GString.txt
Show resolved
Hide resolved
| * More than one deployment descriptor found. | ||
| * No deployment descriptor found. | ||
|
|
||
| Deployment descriptors found: ${files} |
There was a problem hiding this comment.
This message is intended for the end user. It may not be clear, if it shows an empty list in case there are no descriptors.
Ideally, we should be able to tell the user the exact reason of the failure.
There was a problem hiding this comment.
The end user is a developer. I would expect some prior knowledge here. Any suggestions what it should look like?
…m-chartdir-option # Conflicts: # CHANGELOG.md
Closed
hrcornejo
changed the title
…m-chartdir-option
hrcornejo
approved these changes
Apr 30, 2024
BraisVQ
pushed a commit
that referenced
this pull request
Jun 6, 2024
#1044) Co-authored-by: serverhorror <serverhorror@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will bail out if the repository is ambigious about the deployment descriptor.
It will fail if:
For a successfull release to happen, developers are required to "clean" their repository of unrelated deployment desciptors that could interfere with the current version.
related with #1038