Expose bitbucketUrl, taken from BITBUCKET_URL if present #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following this, we should update od-core to set BITBUCKET_URL instead of BITBUCKET_HOST. Older projects still using BITBUCKET_HOST will continue to work as HTTPS is already assumed at the moment. Therefore, I consider this a non-breaking change. It should not be needed to run any migration script to convert old projects as HTTPS should be used in real environments anyway, the HTTP variant only exists for (temporary) testing/local environments.
hugowschneider
approved these changes
Jan 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following this, we should update ods-core to set BITBUCKET_URL instead of
BITBUCKET_HOST. Older projects still using BITBUCKET_HOST will continue
to work as HTTPS is already assumed at the moment.
Therefore, I consider this a non-breaking change. It should not be
needed to run any migration script to convert old projects as HTTPS
should be used in real environments anyway, the HTTP variant only exists
for (temporary) testing/local environments.
Addresses one part of #74.