Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #183.
Implements in the shared lib what is needed to finish opendevstack/ods-core#259 eventually.
Instead of making this a breaking change, the approach here is to support
NEXUS_HOST
as is for ODS 3. But projects created with ODS 3 will setNEXUS_URL
instead ofNEXUS_HOST
and consequently havenexusUrl
andnexusHost
set to the expected values. Users of ODS have the choice during upgrade from 2 to 3 if they want to "fix" the Nexus config by settingNEXUS_URL
in their Jenkins instance, or if they want to stick with the "broken" Nexus config by keepingNEXUS_HOST
. I will document this in the update guide once I make the change inods-core
.The PR also removes code duplication between the three pipelines, making reading of the env vars consistent. While doing that, I noticed that the orchestration pipeline assumed
NEXUS_URL
to be present, but I cannot see how that is set in the release-manager quickstarter at the moment. Now it works whetherNEXUS_URL
is set or not.Given this PR will clash with #365, I can wait with merging after #365 is in, given that's the bigger changeset.