Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling of Unit tests in D and DevPreview #827

Merged
merged 8 commits into from
Jan 25, 2022

Conversation

hrcornejo
Copy link
Contributor

  • The execution status of all Unit tests, for all components, are reported into Jira.
  • The DTR document is generated and contains information that is consistent with Jira.
  • When doing a Developer Preview, the Release Manager pipeline fails only at the end of the Finalize Stage.
  • When deploying to DEV, the Release Manager pipeline fails at the end of the Build Stage.
  • The Release Manager reports the the failure status into its Release Status issue.

@metmajer
Copy link
Member

It would be nice, but I am not sure if this implementation will make the requirements. Consider that a component might decide to fail the build after the first failing unit tests. Currently, components are executed in groups with a failFast property. Therefore, after one failing component, the release manager pipeline would fail.

@hrcornejo
Copy link
Contributor Author

It would be nice, but I am not sure if this implementation will make the requirements. Consider that a component might decide to fail the build after the first failing unit tests. Currently, components are executed in groups with a failFast property. Therefore, after one failing component, the release manager pipeline would fail.

@metmajer added failFast dependent of WIP.
With 2 projects in parallel with this configuration:
image
Launching a WIP all the stages are executed, doc generated and issues updated in Jenkins (with failing tests in one component):
image
Launching a 1.1 version to DEV, the pipeline fails after Build:
image

@metmajer
Copy link
Member

@hrcornejo fantastic! Interestingly, in the second example, the pipeline fails, but we don't see that the component failed. I assume this is because the component itself does not throw an exception/error on test failure?

@hrcornejo
Copy link
Contributor Author

@hrcornejo fantastic! Interestingly, in the second example, the pipeline fails, but we don't see that the component failed. I assume this is because the component itself does not throw an exception/error on test failure?

Right.

@opendevstack opendevstack deleted a comment from hrcornejo Jan 20, 2022
s2oBCN
s2oBCN previously approved these changes Jan 21, 2022
@hrcornejo hrcornejo merged commit 81fe0f9 into master Jan 25, 2022
@hrcornejo hrcornejo deleted the feature/WIP-not-fail-fast branch January 25, 2022 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants