Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set test summary for empty description in TCR #837

Merged
merged 3 commits into from
Feb 2, 2022

Conversation

angelmp01
Copy link
Contributor

No description provided.

s2oBCN
s2oBCN previously approved these changes Feb 2, 2022
jorge-romero
jorge-romero previously approved these changes Feb 2, 2022
@angelmp01 angelmp01 marked this pull request as ready for review February 2, 2022 13:31
@angelmp01 angelmp01 merged commit 02d70bc into master Feb 2, 2022
@angelmp01 angelmp01 deleted the feture/test-summary-for-empty-description-in-TCR branch February 2, 2022 13:57
angelmp01 added a commit that referenced this pull request Feb 2, 2022
* Set test summary for empty description in TCR and added getTestDescription test
# Conflicts:
#	src/org/ods/orchestration/usecase/LeVADocumentUseCase.groovy
angelmp01 added a commit that referenced this pull request Feb 2, 2022
angelmp01 added a commit that referenced this pull request Feb 2, 2022
….x (#839)

* Set test summary for empty description in TCR and added getTestDescription test
# Conflicts:
#	src/org/ods/orchestration/usecase/LeVADocumentUseCase.groovy
* Fixed test
@metmajer
Copy link
Member

@angelmp01 @s2oBCN I noticed that the behaviour for calculating data.description in TCR is different from the TCP. Any particular reasons for this? Implementation should be the same, please pay attention to consistency of our code where consistency must occur. FYI @jafarre-viewnext

jorge-romero pushed a commit that referenced this pull request Feb 14, 2022
* Set test summary for empty description in TCR and added getTestDescription test
hrcornejo added a commit to opendevstack/ods-document-generation-svc that referenced this pull request Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants