Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable linting for typescript build task #325

Closed
henninggross opened this issue Dec 9, 2021 · 0 comments · Fixed by #333
Closed

Enable linting for typescript build task #325

henninggross opened this issue Dec 9, 2021 · 0 comments · Fixed by #333
Assignees
@henninggross
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@henninggross
Copy link
Member

Currently the build-typescript task does not have a linting stage and I would like to change this.

For that I would like to use eslint and also implement the generation of some kind of artifact as proposed for go in #215
@henninggross henninggross added enhancement New feature or request good first issue Good for newcomers labels Dec 9, 2021
@henninggross henninggross self-assigned this Dec 9, 2021
@henninggross henninggross changed the title Enable linting for typescript build Enable linting for typescript build task Dec 9, 2021
@henninggross henninggross mentioned this issue Dec 10, 2021
Merged
4 tasks
michaelsauter added a commit that referenced this issue Dec 21, 2021
@michaelsauter
Generate lint report
abfb459 
Closes #215.

Implementation mirrors #325.
michaelsauter added a commit that referenced this issue Dec 22, 2021
@michaelsauter
Generate lint report
e87c204 
Closes #215.

Implementation mirrors #325.

The change includes updates to the task documentation. It also ensures
a pre-test script is only executed when tests are executed.
@michaelsauter michaelsauter mentioned this issue Dec 22, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@henninggross henninggross

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add linting stage to TypeScript build task opendevstack/ods-pipeline
1 participant
@henninggross