Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider removing PVC use protection #647

Closed
michaelsauter opened this issue Jan 10, 2023 · 0 comments · Fixed by #655
Closed

Consider removing PVC use protection #647

michaelsauter opened this issue Jan 10, 2023 · 0 comments · Fixed by #655

Comments

@michaelsauter
Copy link
Member

The workspace PVC is use protected right now. This can lead to PVCs stuck in "terminating" state. Maybe it would be better to remove this protection to make it easier to delete a PVC. One "common" use case for deleting the workspace PVC is if it runs out of disk space. In that case, the pipeline run fails, and the PVC will get stuck "terminating" because there are still failed pods that reference the workspace PVC.

For more information, see https://kubernetes.io/docs/concepts/storage/persistent-volumes/#storage-object-in-use-protection.
michaelsauter added a commit that referenced this issue Feb 15, 2023
@michaelsauter
Remove PVC use protection
e9fea5e 
It often gets in the way of cleaning up, and does not provide value for
us as the PVC should not contain any data that isn't safe to throw away.

Closes #647.
@michaelsauter michaelsauter mentioned this issue Feb 15, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove PVC use protection opendevstack/ods-pipeline
1 participant
@michaelsauter