Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect images to be built automatically #287

Merged
merged 3 commits into from
Nov 16, 2021

Conversation

henninggross
Copy link
Member

Previously the images to be built via build-and-push-images.sh were determined via this line in the script itself:

IMAGES="buildah finish go-toolset gradle-toolset helm sonar start webhook-interceptor python-toolset"

As this is a hardcoded list it could happen (as it did with Typescript) that new images are added as a Dockerfile that are not added to this list.

With this change the script now iterates over the contents of /build/package/ and retrieves the images to be built from this, which should not lead to missing images anymore.

Fixes #286

Tasks:

  • Updated design documents in docs/design directory or not applicable
  • Updated user-facing documentation in docs directory or not applicable
  • Ran tests (e.g. make test) or not applicable
  • Updated changelog or not applicable

@henninggross henninggross changed the title Feature/detect images to be built automatically Detect images to be built automatically Nov 16, 2021
Copy link
Member

@michaelsauter michaelsauter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@michaelsauter michaelsauter merged commit 3f072a7 into master Nov 16, 2021
@michaelsauter michaelsauter deleted the feature/detect-images-to-be-built-automatically branch November 16, 2021 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typescript Toolset is not being build and pushed to registry
2 participants