Detect images to be built automatically #287
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the images to be built via
build-and-push-images.sh
were determined via this line in the script itself:IMAGES="buildah finish go-toolset gradle-toolset helm sonar start webhook-interceptor python-toolset"
As this is a hardcoded list it could happen (as it did with Typescript) that new images are added as a Dockerfile that are not added to this list.
With this change the script now iterates over the contents of
/build/package/
and retrieves the images to be built from this, which should not lead to missing images anymore.Fixes #286
Tasks:
docs/design
directory or not applicabledocs
directory or not applicablemake test
) or not applicable