Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed specifying image(s) to be build and pushed #300

Merged
merged 2 commits into from
Nov 23, 2021

Conversation

henninggross
Copy link
Member

Fixes an issue that came up due to changes made in #287 which resulted in all images being built and pushed even when running

./scripts/build-and-oush-images.sh --image foo

Fixes #299

Tasks:

  • Updated design documents in docs/design directory or not applicable
  • Updated user-facing documentation in docs directory or not applicable
  • Ran tests (e.g. make test) or not applicable
  • Updated changelog or not applicable

@henninggross henninggross added the bug Something isn't working label Nov 23, 2021
@henninggross
Copy link
Member Author

I am not that familiar with bash still, so feedback is highly appreciated on this one.

@michaelsauter
Copy link
Member

Do you know https://www.shellcheck.net? This can help to uncover some "mistakes" :) See also #240.

The change looks good. The combination of loop / global variable / function invocation makes me a bit uneasy, but I also would have to look up how to make it better.

Let me know if you want to do a 2nd round with my recommendations above, otherwise this LGTM.

@henninggross
Copy link
Member Author

Actually I did not know that tool, thanks for pointing me to it.

I am happy to apply the changes it proposes (missing double quotes) but when it comes to the structure of the code I currently don't have the knowledge on shell best practices and would leave it as is.
Glad for anyone to take this up if they see a need though.

@michaelsauter michaelsauter merged commit 5a0d64d into master Nov 23, 2021
@michaelsauter michaelsauter deleted the fix/specifying-image-not-working branch November 23, 2021 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specifying images to be build and pushed not possible anymore
2 participants