-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update maven-agent, springboot & spock-geb quickstarter #901
Conversation
Thanks for the contribution @renedupont |
@renedupont , open question. Should the agent be renamed ? |
Yes, what about just |
Jdk makes more sense. Also I have tested this:
|
@renedupont , we have the ok for the name change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested current build, provision and retrocompatibility with old QS version successfully.
The use of Maven wrapper also works as expected for the use cases that needs maven
This PR introduces the below changes:
spock-geb qs:
be-springboot qs:
maven-agent:
Note: Removing gradle and maven from the agent is a breaking change for projects that don't use either gradle or maven wrapper in their projects. The fix in these cases would be to start using the wrapper approach. If adapting is not possible right away, the old maven agent could be used via ref.
closes #878