Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update maven-agent, springboot & spock-geb quickstarter #901

Merged
merged 11 commits into from
May 2, 2023

Conversation

renedupont
Copy link
Member

@renedupont renedupont commented Mar 31, 2023

This PR introduces the below changes:

spock-geb qs:

  • raises dependencies and gradle version

be-springboot qs:

  • raises springboot + dependencies, ubi image and gradle version
  • removes restdocs as dependency
  • fixes param names of spring initializr call
  • updates removed jacoco xml setting in build.gradle (xml.enabled was removed in gradle 8 in favor of xml.required)

maven-agent:

  • adds temporary java17 switch bugfix in Dockerfile
  • removes gradle and maven installation (due to usage of wrapper in projects) while keeping proxy and nexus settings for them

Note: Removing gradle and maven from the agent is a breaking change for projects that don't use either gradle or maven wrapper in their projects. The fix in these cases would be to start using the wrapper approach. If adapting is not possible right away, the old maven agent could be used via ref.

closes #878

@renedupont renedupont changed the title WIP: raise versions for springboot qs WIP: raise versions for springboot & spock-geb qs Mar 31, 2023
@renedupont renedupont changed the title WIP: raise versions for springboot & spock-geb qs Update maven-agent, springboot & spock-geb quickstarter Apr 19, 2023
@renedupont renedupont requested a review from BraisVQ April 19, 2023 10:04
@BraisVQ
Copy link
Contributor

BraisVQ commented Apr 24, 2023

Thanks for the contribution @renedupont
I will try to test it to ensure retrocompatibility and prepare internal documentatio in case maven users still need to use it

@BraisVQ
Copy link
Contributor

BraisVQ commented Apr 26, 2023

@renedupont , open question. Should the agent be renamed ?
Currently its name is maven but we have removed maven from it.

@renedupont
Copy link
Member Author

Yes, what about just java-agent, or even better jdk-agent?

@BraisVQ
Copy link
Contributor

BraisVQ commented Apr 26, 2023

Jdk makes more sense.
I will check internally first but there should not be any issue changing the agent name.

Also I have tested this:

  • Provision both quickstarters with new agent
  • Test maven wrapper approach
  • Provision both qs with old version of the agent and qs, then build them with new agent successfully (without changes).

@BraisVQ
Copy link
Contributor

BraisVQ commented May 2, 2023

@renedupont , we have the ok for the name change.

Copy link
Contributor

@BraisVQ BraisVQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested current build, provision and retrocompatibility with old QS version successfully.
The use of Maven wrapper also works as expected for the use cases that needs maven

@renedupont renedupont merged commit e2192f3 into master May 2, 2023
@BraisVQ BraisVQ deleted the feature/878-maintenance-java-qs-agent branch May 30, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance of Maven agent, Java and Spock-Geb quickstarter
2 participants