This repository has been archived by the owner on Aug 9, 2022. It is now read-only.
Backport from dev branch #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r-elasticsearch#284) * Add mutex to lock on creating report using puppeteer * Use semaphore instead of mutex * change semaphore limit to 1 * Add 30 seconds timeout * Change timeout to 180 sec, add error message * Update error message * Add unit test for timeout error
Codecov Report
@@ Coverage Diff @@
## 7.9.1 #289 +/- ##
==========================================
+ Coverage 70.10% 72.85% +2.75%
==========================================
Files 32 32
Lines 1773 1809 +36
Branches 343 357 +14
==========================================
+ Hits 1243 1318 +75
+ Misses 525 486 -39
Partials 5 5
Continue to review full report at Codecov.
|
zhongnansu
requested review from
akbhatta,
joshuali925,
davidcui1225 and
abbashus
abbashus
approved these changes
Jan 6, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
backport from
devto7.9.1, from commit 35dfe7d to 1bf159cBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.