-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(helm): add cstor operators and csi helm charts #180
Conversation
Please add the CRD for UpgradeTask https://github.com/openebs/charts/blob/c3351b3ac95b4105f069d44ee59ac4f7d5498240/1.12.0/cstor-operator-1.12.0.yaml#L348 |
@sonasingh46 Another CRD needs to be added to the charts. Please include it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
given a few comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@prateekpandey14 Can you change the NDM version also
Signed-off-by: prateekpandey14 <prateek.pandey@mayadata.io>
77eb7de
to
f484e73
Compare
Signed-off-by: prateekpandey14 <prateek.pandey@mayadata.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@prateekpandey14 @sonasingh46 I have completed my round of reviews.
I would recommend someone who is more familiar with cstor to take a closer look at the components to make sure everything is perfect. cc: @shubham14bajpai
Signed-off-by: prateekpandey14 <prateek.pandey@mayadata.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@prateekpandey14 -- Thanks a lot for raising commits in this PR and helping me out. |
Signed-off-by: prateekpandey14 <prateek.pandey@mayadata.io>
42d8857
to
d1669c5
Compare
Why is this PR required? What issue does it fix?:
Add helm chart for openebs cstor operators and csi driver
Helm install dry-run output :
fixes #161
Signed-off-by: Ashutosh Kumar ashutosh.kumar@mayadata.io