Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(upgrade): upgrade instruction for nfs-provisioner #123

Merged
merged 3 commits into from
Nov 8, 2021

Conversation

mynktl
Copy link
Contributor

@mynktl mynktl commented Oct 25, 2021

Why is this PR required? What issue does it fix?:

What this PR does?:
This PR adds upgrade instruction for nfs-provisioner and nfs-server deployments.

Does this PR require any upgrade changes?: No

If the changes in this PR are manually verified, list down the scenarios covered::

Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

  • Fixes #
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Has the change log section been updated?
  • Commit has unit tests
  • Commit has integration tests
  • (Optional) Does this PR change require updating NFS-Provisioner Chart? If yes, mention the Helm Chart PR #
  • (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
  • (Optional) If documentation changes are required, which issue on https://github.com/openebs/openebs-docs is used to track them:

Signed-off-by: mayank <mayank.patel@mayadata.io>
@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2021

Codecov Report

Merging #123 (2c18396) into develop (1ae6401) will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #123      +/-   ##
===========================================
- Coverage    49.88%   49.79%   -0.10%     
===========================================
  Files           38       38              
  Lines         2700     2705       +5     
===========================================
  Hits          1347     1347              
- Misses        1250     1255       +5     
  Partials       103      103              
Impacted Files Coverage Δ
provisioner/config.go 9.90% <0.00%> (-2.30%) ⬇️
provisioner/provisioner.go 0.00% <0.00%> (ø)
provisioner/env.go 33.33% <0.00%> (+3.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ae6401...2c18396. Read the comment docs.

Copy link
Contributor

@mittachaitu mittachaitu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provided few comments

docs/tutorial/upgrade.md Show resolved Hide resolved
docs/tutorial/upgrade.md Show resolved Hide resolved
docs/tutorial/upgrade-nfs-server.sh Show resolved Hide resolved
@mynktl mynktl mentioned this pull request Oct 26, 2021
18 tasks
Signed-off-by: mayank <mayank.patel@mayadata.io>
Copy link
Contributor

@mittachaitu mittachaitu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


kubectl patch deploy -n ${NFS_SERVER_NS} ${deploymentName} -p "${patchJson}" > /dev/null
exitCode=$?
if [ $exitCode -ne 0 ]; then
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens in the following case:

  • There are 2 nfs server deployments
  • First run successfully upgraded 1 of them to latest images and script exited due to network issues or some other case
  • User tries to upgrade again the remaining ones
  • Will the first one be skipped or does the patch command return an error and not continue with upgrading next nfs server.

Also, can we have an optional parameter that says if user should upgrade only one PVC instead of all PVCs..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case of a partial upgrade, the second execution of the upgrade script will skip the upgrade for already upgraded deployment and proceed with the upgrade for non-upgraded nfs-server deployments.

I've updated the script to upgrade specific nfs-server deployment. Also updated the upgrade document with the command for the same.

Signed-off-by: mayank <mayank.patel@mayadata.io>
@kmova kmova merged commit f2baa53 into openebs-archive:develop Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants