-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc(upgrade): upgrade instruction for nfs-provisioner #123
Conversation
Signed-off-by: mayank <mayank.patel@mayadata.io>
Codecov Report
@@ Coverage Diff @@
## develop #123 +/- ##
===========================================
- Coverage 49.88% 49.79% -0.10%
===========================================
Files 38 38
Lines 2700 2705 +5
===========================================
Hits 1347 1347
- Misses 1250 1255 +5
Partials 103 103
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Provided few comments
Signed-off-by: mayank <mayank.patel@mayadata.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
||
kubectl patch deploy -n ${NFS_SERVER_NS} ${deploymentName} -p "${patchJson}" > /dev/null | ||
exitCode=$? | ||
if [ $exitCode -ne 0 ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens in the following case:
- There are 2 nfs server deployments
- First run successfully upgraded 1 of them to latest images and script exited due to network issues or some other case
- User tries to upgrade again the remaining ones
- Will the first one be skipped or does the patch command return an error and not continue with upgrading next nfs server.
Also, can we have an optional parameter that says if user should upgrade only one PVC instead of all PVCs..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In case of a partial upgrade, the second execution of the upgrade script will skip the upgrade for already upgraded deployment and proceed with the upgrade for non-upgraded nfs-server deployments.
I've updated the script to upgrade specific nfs-server deployment. Also updated the upgrade document with the command for the same.
Signed-off-by: mayank <mayank.patel@mayadata.io>
Why is this PR required? What issue does it fix?:
What this PR does?:
This PR adds upgrade instruction for nfs-provisioner and nfs-server deployments.
Does this PR require any upgrade changes?: No
If the changes in this PR are manually verified, list down the scenarios covered::
Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>