Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support zstd-fast compression options #501

Closed
danielkza opened this issue Feb 7, 2024 · 2 comments
Closed

Support zstd-fast compression options #501

danielkza opened this issue Feb 7, 2024 · 2 comments
Assignees
Labels
e2e/zfs-localpv To be picked up as an e2e/testing item. enhancement Add new functionality to existing feature help wanted Need help from community contributors.
Milestone

Comments

@danielkza
Copy link

Describe the problem/challenge you have

zstd-fast compression option is not supported.

Describe the solution you'd like
[A clear and concise description of what you want to happen.]

zfst-fast compression options are supported.

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

E0207 17:50:59.680039       1 controller.go:957] error syncing claim "524024ec-2367-4052-b700-061db300370f": failed to provision volume with StorageClass "zfs-default": rpc error: code = Internal desc = not able to provision the volume, nodes [e11e9d9712994bccbb885e70e108e22c], err : ZFSVolume.zfs.openebs.io "pvc-524024ec-2367-4052-b700-061db300370f" is invalid: spec.compression: Invalid value: "zstd-fast": spec.compression in body should match '^(on|off|lzjb|zstd|zstd-[1-9]|zstd-1[0-9]|gzip|gzip-[1-9]|zle|lz4)$'

Environment:

  • ZFS-LocalPV version
    2.4.1 from Helm Chart

  • Kubernetes version (use kubectl version):
    1.29

  • Kubernetes installer & version:
    RKE2

  • Cloud provider or hardware configuration:
    Bare metal

  • OS (e.g. from /etc/os-release):
    Fedora 38.

@orville-wright orville-wright added enhancement Add new functionality to existing feature help wanted Need help from community contributors. feature e2e/zfs-localpv To be picked up as an e2e/testing item. labels Mar 27, 2024
@orville-wright orville-wright self-assigned this Mar 27, 2024
@orville-wright
Copy link
Contributor

orville-wright commented Mar 27, 2024

thanks @danielkza
Since the Zstandard lossless data compression algorithm has been included in Linux kernel from 2017 and OpenZFS since 2020, it feels reasonable that this option should be available in our ZFS-LocalPV Data Engine.

I will track this feature request and see when we can schedule it for inserting into a future release.

@Abhinandan-Purkait
Copy link
Member

@danielkza This has been added, you can try this with the latest develop tag. It should be available in 4.2 openebs release. Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e/zfs-localpv To be picked up as an e2e/testing item. enhancement Add new functionality to existing feature help wanted Need help from community contributors.
Projects
None yet
Development

No branches or pull requests

4 participants