chore(doc): Update docs for Gomodule support #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #160 +/- ##
=======================================
Coverage 22.65% 22.65%
=======================================
Files 14 14
Lines 490 490
=======================================
Hits 111 111
Misses 378 378
Partials 1 1 Continue to review full report at Codecov.
|
|
@vaniisgh can you add change log in this PR? |
|
not sure why my re-base did this .. should I open a fresh PR? |
you can fix the changes, and force push(git push -f) here in the same PR only. |
pawanpraka1
reviewed
Jun 26, 2020
pawanpraka1
reviewed
Jun 26, 2020
pawanpraka1
added
Need community involvement
|
@vaniisgh can you DCO sign off all the commits? Few commits are not having DCO sign, not able to merge it. |
|
yes sorry about all this, my focus is not good at the moment. |
- updated docs to reflect use of gomodules Signed-off-by: vaniisgh <vanisingh@live.co.uk>
Signed-off-by: vaniisgh <vanisingh@live.co.uk>
Signed-off-by: vaniisgh <vanisingh@live.co.uk>
pawanpraka1
changed the title
pawanpraka1
added a commit
to pawanpraka1/zfs-localpv
that referenced
this pull request
Jul 9, 2020
Following PR added for changelog - openebs#166 - openebs#171 - openebs#172 - openebs#164 - openebs#160 - openebs#167 - openebs#170 - openebs#161 - openebs#174 - openebs#175 Signed-off-by: Pawan <pawan@mayadata.io>
7 tasks
pawanpraka1
added a commit
to pawanpraka1/zfs-localpv
that referenced
this pull request
Jul 9, 2020
Following PR added for changelog - openebs#166 - openebs#171 - openebs#172 - openebs#164 - openebs#160 - openebs#167 - openebs#170 - openebs#161 - openebs#174 - openebs#175 Signed-off-by: Pawan <pawan@mayadata.io>
pawanpraka1
added a commit
to pawanpraka1/zfs-localpv
that referenced
this pull request
Jul 13, 2020
Following PR added for changelog - openebs#166 - openebs#171 - openebs#172 - openebs#164 - openebs#160 - openebs#167 - openebs#170 - openebs#161 - openebs#174 - openebs#175 Signed-off-by: Pawan <pawan@mayadata.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Files Changed
Why is this PR required? What issue does it fix?:
Updating docs as well as a very small fix in the build scripts to support go modules.
What this PR does?:
Adds the required updates.
Any additional information for your reviewer? :
Just a small question about this file zfs-localpv/buildscripts/zfs-driver/Dockerfile
this line
RUN apt-get -y install rsyslog libssl-dev xfsprogs ca-certificatesbreaks code on my local machine, should I expect this? and how can I fix this ? :)Checklist:
<type>(<scope>): <subject>