feat(shared): adding shared mount support ZFSPV volumes #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #164 +/- ##
=======================================
Coverage 22.65% 22.65%
=======================================
Files 14 14
Lines 490 490
=======================================
Hits 111 111
Misses 378 378
Partials 1 1 Continue to review full report at Codecov.
|
pawanpraka1
force-pushed
the
shared
branch
2 times, most recently
from
b5e2697
to
3f312d6
Compare
pawanpraka1
force-pushed
the
shared
branch
2 times, most recently
from
d3652a8
to
5e06772
Compare
Applications who want to share a volume can use below storageclass to make their volumes shared by multiple pods ```yaml apiVersion: storage.k8s.io/v1 kind: StorageClass metadata: name: openebs-zfspv parameters: shared: "yes" fstype: "zfs" poolname: "zfspv-pool" provisioner: zfs.csi.openebs.io ``` Now the provisioned volume using this storageclass can be used by multiple pods. Here pods have to make sure of the data consistency and have to have locking mechanism. One thing to note here is pods will be scheduled to the node where volume is present so that all the pods can use the same volume as they can access it locally only. This was we can avoid the NFS overhead and can get the optimal performance also. Also fixed the log formatting in the GRPC log. Signed-off-by: Pawan <pawan@mayadata.io>
kmova
approved these changes
Jul 1, 2020
pawanpraka1
added a commit
to pawanpraka1/zfs-localpv
that referenced
this pull request
Jul 9, 2020
Following PR added for changelog - openebs#166 - openebs#171 - openebs#172 - openebs#164 - openebs#160 - openebs#167 - openebs#170 - openebs#161 - openebs#174 - openebs#175 Signed-off-by: Pawan <pawan@mayadata.io>
7 tasks
pawanpraka1
added a commit
to pawanpraka1/zfs-localpv
that referenced
this pull request
Jul 9, 2020
Following PR added for changelog - openebs#166 - openebs#171 - openebs#172 - openebs#164 - openebs#160 - openebs#167 - openebs#170 - openebs#161 - openebs#174 - openebs#175 Signed-off-by: Pawan <pawan@mayadata.io>
pawanpraka1
added a commit
to pawanpraka1/zfs-localpv
that referenced
this pull request
Jul 13, 2020
Following PR added for changelog - openebs#166 - openebs#171 - openebs#172 - openebs#164 - openebs#160 - openebs#167 - openebs#170 - openebs#161 - openebs#174 - openebs#175 Signed-off-by: Pawan <pawan@mayadata.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes : #152
Signed-off-by: Pawan pawan@mayadata.io
Why is this PR required? What issue does it fix?:
Applications who wants to share a volume can use below storageclass
to make their volumes shared by multiple pods
Now the provisioned volume using this storageclass can be used by multiple pods.
Here pods have to make sure of the data consistency and have to have locking mechanism.
One thing to note here is pods will be scheduled to the node where volume is present
so that all the pods can use the same volume as they can access it locally only.
This way we can avoid the NFS overhead and can get the optimal performance also.
What this PR does?:
Add a new field "shared" which specifies that the volume can be shared mounted.
Also fixed the log formatting in the GRPC log.
Does this PR require any upgrade changes?:
no
Checklist:
<type>(<scope>): <subject>