-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(zfspv) add go lint target #167
Conversation
Signed-off-by: vaniisgh <vanisingh@live.co.uk>
Signed-off-by: vaniisgh <vanisingh@live.co.uk>
Codecov Report
@@ Coverage Diff @@
## master #167 +/- ##
=======================================
Coverage 22.65% 22.65%
=======================================
Files 14 14
Lines 490 490
=======================================
Hits 111 111
Misses 378 378
Partials 1 1 Continue to review full report at Codecov.
|
@vaniisgh this looks good. are there any golint error you are getting? if yes, would you like to fix them in the coming PR? We will add |
so, I'll fix the other recommendations in this PR and the go-lint errors in a new one? :) right? |
fix the recommendation given in this PR only. And for fixing the go-lint and adding it to the travis can be taken in a new PR. |
Also, add the changelog file. |
Signed-off-by: vaniisgh <vanisingh@live.co.uk>
I'll fix the linting errors & add to Travis in a new PR, should I open an issue for the same ... I'll take care of it in a day or two though :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good.
@vaniisgh yes, you can open an issue for that. |
Following PR added for changelog - openebs#166 - openebs#171 - openebs#172 - openebs#164 - openebs#160 - openebs#167 - openebs#170 - openebs#161 - openebs#174 - openebs#175 Signed-off-by: Pawan <pawan@mayadata.io>
Following PR added for changelog - openebs#166 - openebs#171 - openebs#172 - openebs#164 - openebs#160 - openebs#167 - openebs#170 - openebs#161 - openebs#174 - openebs#175 Signed-off-by: Pawan <pawan@mayadata.io>
Following PR added for changelog - openebs#166 - openebs#171 - openebs#172 - openebs#164 - openebs#160 - openebs#167 - openebs#170 - openebs#161 - openebs#174 - openebs#175 Signed-off-by: Pawan <pawan@mayadata.io>
Why is this PR required? What issue does it fix?:
adds a target for lint as needed by #165
Questions
should the golint output be formatted before printing somehow ... ?
also i need to fix the spelling for recommendations, will do with the change-log or any additional changes :)
Checklist:
<type>(<scope>): <subject>