Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: setup datadog instrumentation #428

Merged
merged 1 commit into from
Apr 5, 2024
Merged

feat: setup datadog instrumentation #428

merged 1 commit into from
Apr 5, 2024

Conversation

saadyousafarbi
Copy link
Contributor

Description

Setting datadog instrumentation for forum service.

@saadyousafarbi saadyousafarbi force-pushed the saad/dd-setup branch 2 times, most recently from ad2581e to 9c631de Compare April 4, 2024 10:10
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.19%. Comparing base (0dc490e) to head (2e4f302).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #428   +/-   ##
=======================================
  Coverage   96.19%   96.19%           
=======================================
  Files          58       58           
  Lines        4624     4624           
=======================================
  Hits         4448     4448           
  Misses        176      176           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@saadyousafarbi saadyousafarbi force-pushed the saad/dd-setup branch 5 times, most recently from 114f2f9 to e304836 Compare April 5, 2024 11:13
@nadeemshahzad nadeemshahzad merged commit 8626d44 into master Apr 5, 2024
16 checks passed
@nadeemshahzad nadeemshahzad deleted the saad/dd-setup branch April 5, 2024 13:53
@dianakhuang
Copy link
Contributor

We're seeing issues on local devstack provisioning with this new DD requirement. Would it be possible to add some sort of flag to disable the requirement for various environments and also for Open edX community members who aren't using DD on their own production systems?

@ghassanmas
Copy link
Member

Hey folks,
FYI I had to open #429 in order to add it to Gemfile given this change adds it to Gemfile3 only.
Otherwise it would break for me. If you could 👍🏾 or 👎🏾 that would be much appercaited.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants