Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade react router to v6 #344

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

Syed-Ali-Abbas-Zaidi
Copy link
Contributor

@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi commented Jul 7, 2023

Ticket

React Router Upgrade to v6.

Description

This PR upgrades React Router from v5 to v6.

BREAKING CHANGES

  • Upgrade react-router-dom from v5 to v6
  • Upgrade frontend-platform from v4 to v5.

Merge checklist:

  • Evaluate how your changes will impact existing consumers (e.g., frontend-app-learner-portal-enterprise, frontend-app-admin-portal, and frontend-app-enterprise-public-catalog). Will consumers safely be able to upgrade to this change without any breaking changes?
  • Ensure your commit message follows the semantic-release conventional commit message format. If your changes include a breaking change, ensure your commit message is explicitly marked as a BREAKING CHANGE so the NPM package is released as such.
  • Once CI is passing, verify the package versions that Lerna will increment to in the Github Action CI workflow logs.
    • Note: This may be found in the "Preview Updated Versions (dry run)" step in the Github Action CI workflow logs.

Post merge:

  • Verify Lerna created a release commit (e.g., chore(release): publish) that incremented versions in relevant package.json and CHANGELOG files, and created Git tags for those versions.
  • Run the Publish from package.json Github Action workflow to publish these new package versions to NPM.
    • This may be triggered by clicking the "Run workflow" option for the master branch.
  • Verify the new package versions were published to NPM (i.e., npm view <package_name> versions --json).
    • Note: There may be a slight delay between when the workflow finished and when NPM reports the package version as being published. If it doesn't appear right away in the above command, try again in a few minutes.

@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi force-pushed the Ali-Abbas/router-dom-upgrade branch 3 times, most recently from 7881ba8 to 389962f Compare July 7, 2023 13:37
@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi marked this pull request as draft July 10, 2023 12:44
@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi force-pushed the Ali-Abbas/router-dom-upgrade branch 2 times, most recently from f7a8d96 to cd8c8b0 Compare July 12, 2023 10:16
@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi force-pushed the Ali-Abbas/router-dom-upgrade branch 15 times, most recently from f67f7c1 to 8a3e6be Compare July 14, 2023 12:04
@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Merging #344 (01f239a) into master (5241cc1) will not change coverage.
Report is 2 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #344   +/-   ##
=======================================
  Coverage   78.26%   78.26%           
=======================================
  Files          34       34           
  Lines         667      667           
  Branches      172      172           
=======================================
  Hits          522      522           
  Misses        132      132           
  Partials       13       13           
Files Changed Coverage Δ
...ckages/catalog-search/src/SearchSuggestionItem.jsx 100.00% <ø> (ø)
packages/utils/src/test-utils.jsx 0.00% <ø> (ø)
packages/catalog-search/src/SearchContext.jsx 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5241cc1...01f239a. Read the comment docs.

@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi force-pushed the Ali-Abbas/router-dom-upgrade branch 3 times, most recently from ecc578d to 02931ab Compare August 8, 2023 08:50
@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi marked this pull request as ready for review August 8, 2023 08:55
@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi force-pushed the Ali-Abbas/router-dom-upgrade branch 3 times, most recently from b6fe686 to d19c7ec Compare August 8, 2023 09:49
Copy link
Member

@adamstankiewicz adamstankiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! To verify, will these changes will be released as a major, breaking release?

@Syed-Ali-Abbas-Zaidi
Copy link
Contributor Author

Yes, This will be a major release.

@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi merged commit 54f6340 into master Aug 15, 2023
9 checks passed
@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi deleted the Ali-Abbas/router-dom-upgrade branch August 15, 2023 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants