-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BD-46] fix: remove props spreading in DataTable
components
#2812
[BD-46] fix: remove props spreading in DataTable
components
#2812
Conversation
Thanks for the pull request, @PKulkoRaccoonGang! When this pull request is ready, tag your edX technical lead. |
✅ Deploy Preview for paragon-openedx ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
DataTable
componentsDataTable
components
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2812 +/- ##
=======================================
Coverage 92.83% 92.83%
=======================================
Files 235 235
Lines 4240 4240
Branches 1029 1029
=======================================
Hits 3936 3936
Misses 300 300
Partials 4 4 ☔ View full report in Codecov by Sentry. |
@PKulkoRaccoonGang 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
🎉 This PR is included in version 21.7.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 22.0.0-alpha.16 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Removes redundant props spreading in DataTable subcomponents that cause a lot of console errors during development, more details in #2751
Merge Checklist
example
app?wittjeff
andadamstankiewicz
as reviewers on this PR.Post-merge Checklist