Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added new svgs for sidebar filled and outlined #2952

Merged
merged 3 commits into from
Dec 22, 2023
Merged

feat: added new svgs for sidebar filled and outlined #2952

merged 3 commits into from
Dec 22, 2023

Conversation

sundasnoreen12
Copy link
Contributor

@sundasnoreen12 sundasnoreen12 commented Dec 19, 2023 •
edited
Loading

INF-1184

Description
Added new svgs for sidebar filled and outlined in paragon

@netlify Netlify
Copy link

netlify bot commented Dec 19, 2023 •
edited
Loading

✅ Deploy Preview for paragon-openedx ready!

Name Link
🔨 Latest commit f5ac240
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/6583e83e1479f9000825cf54
😎 Deploy Preview https://deploy-preview-2952--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov Codecov
Copy link

codecov bot commented Dec 19, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (40aea5e) 92.83% compared to head (f5ac240) 92.87%.
Report is 10 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2952      +/-   ##
==========================================
+ Coverage   92.83%   92.87%   +0.03%     
==========================================
  Files         235      235              
  Lines        4245     4268      +23     
  Branches     1032     1033       +1     
==========================================
+ Hits         3941     3964      +23     
  Misses        300      300              
  Partials        4        4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

brian-smith-tcril
brian-smith-tcril requested changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@brian-smith-tcril brian-smith-tcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see an svg file added to icons/svg as a part of this PR, which means this icon would disappear the next time someone runs npm run build for icons as per the icons readme.

@sundasnoreen12 sundasnoreen12 changed the title feat: added new webBlack icon in es5 and js feat: added new svg for sidebar filled and outlined Dec 21, 2023
@sundasnoreen12 sundasnoreen12 changed the title feat: added new svg for sidebar filled and outlined feat: added new svgs for sidebar filled and outlined Dec 21, 2023
@sundasnoreen12
Copy link
Contributor Author

I don't see an svg file added to icons/svg as a part of this PR, which means this icon would disappear the next time someone runs npm run build for icons as per the icons readme.

@brian-smith-tcril I have added svgs. Please review now.

brian-smith-tcril
brian-smith-tcril approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@brian-smith-tcril brian-smith-tcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Running npm run build in the icons dir on this branch works as expected (output matches commit), and everything looks good on the docsite!

image

@viktorrusakov viktorrusakov merged commit de070d2 into master Dec 22, 2023
10 checks passed
@viktorrusakov viktorrusakov deleted the sundas/INF-1184 branch December 22, 2023 08:41
@openedx-semantic-release-bot
Copy link

🎉 This PR is included in version 21.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@openedx-semantic-release-bot
Copy link

🎉 This PR is included in version 22.0.0-alpha.24 🎉

The release is available on:

Your semantic-release bot 📦🚀

khudym pushed a commit to khudym/paragon that referenced this pull request Jan 2, 2024
@sundasnoreen12
feat: added sidebar filled and outlined icons (openedx#2952)
ddd46c8 
* feat: added new webBlack icon in es5 and js

* fix: added web black svg in svg folder

* feat: added new svg for sidebar filled and outlined
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viktorrusakov viktorrusakov viktorrusakov approved these changes

@brian-smith-tcril brian-smith-tcril brian-smith-tcril approved these changes

@asadazam93 asadazam93 Awaiting requested review from asadazam93

@saadyousafarbi saadyousafarbi Awaiting requested review from saadyousafarbi

@muhammadadeeltajamul muhammadadeeltajamul Awaiting requested review from muhammadadeeltajamul

Assignees
No one assigned
Labels
released on @alpha released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sundasnoreen12 @openedx-semantic-release-bot @viktorrusakov @brian-smith-tcril