Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update weather station index and fix tests #57

Merged
merged 2 commits into from
Oct 5, 2019

Conversation

philngo
Copy link
Contributor

@philngo philngo commented Oct 5, 2019

Your checklist for this pull request

Please review the guidelines for contributing to this repository.

  • Make sure you are requesting to pull a feature/bugfix branch (right side). Don't request your master!
  • Make sure tests pass and coverage has not fallen docker-compose run --rm test.
  • Update the CHANGELOG.md to describe your changes in a bulleted list under the "Development" section at the top of the changelog. If this section does not exist, create it.
  • Make sure code style follows PEP 008 using docker-compose run --rm blacken.

Description

Please describe your pull request.

@codecov
Copy link

codecov bot commented Oct 5, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@9f908a7). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master    #57   +/-   ##
=======================================
  Coverage          ?   100%           
=======================================
  Files             ?     32           
  Lines             ?   2650           
  Branches          ?      0           
=======================================
  Hits              ?   2650           
  Misses            ?      0           
  Partials          ?      0
Impacted Files Coverage Δ
tests/test_cli.py 100% <ø> (ø)
tests/test_stations.py 100% <ø> (ø)
tests/snapshots/snap_test_database.py 100% <100%> (ø)
tests/test_ranking.py 100% <100%> (ø)
tests/snapshots/snap_test_stations.py 100% <100%> (ø)
tests/snapshots/snap_test_ranking.py 100% <100%> (ø)
tests/snapshots/snap_test_summaries.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f908a7...1e7dd93. Read the comment docs.

@philngo philngo merged commit 9de9aa2 into master Oct 5, 2019
@philngo philngo deleted the feature/update-db-2019-10-04 branch October 5, 2019 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant