Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DV_DURATION on INTERVAL EVENT #5

Closed
bjornna opened this issue Feb 1, 2015 · 3 comments
Closed

DV_DURATION on INTERVAL EVENT #5

bjornna opened this issue Feb 1, 2015 · 3 comments

Comments

@bjornna
Copy link
Contributor

bjornna commented Feb 1, 2015

I am not sure what is correct with this.

I trying to serialize the Blood Pressure archetype which has an Interval Event.

INTERVAL_EVENT[at1042] 
.... 
width matches {
    DV_DURATION matches {
        value matches {|PT24H|}
    }
}

This is what gets generated:

width matches {
    DV_DURATION matches {
        value matches {[PT24H,PT24H]}
    }
}

The generation of the text {[PT24H,PT24H]} is done in org.openehr.adl.am.mixin.IntervalMixin.
Is this a bug in the IntervalMixin or should the DV_DURATION be treated different in this case?

I am not sure

@wolandscat
Copy link
Member

This is Marko's code, not mine obviously, but the syntax is wrong anyway - it should be || not []. A lesser bug that might be expected would be |PT24H..PT24H|

@bjornna
Copy link
Contributor Author

bjornna commented Feb 1, 2015

Great feedback. I was just re-reading ADL and AOM specification and found some answers there.
I will have a look at the implementation.

@bjornna
Copy link
Contributor Author

bjornna commented Feb 1, 2015

Added a pull request that fixes this. Closing the issue.

@bjornna bjornna closed this as completed Feb 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants