Skip to content
This repository has been archived by the owner on May 24, 2022. It is now read-only.

Add changelogs #96

Closed
amaury1093 opened this issue Jan 16, 2019 · 4 comments
Closed

Add changelogs #96

amaury1093 opened this issue Jan 16, 2019 · 4 comments
Assignees

Comments

@amaury1093
Copy link
Collaborator

#93 introduces a breaking change, we should write changelogs right after.

Maybe with something like https://github.com/lerna/lerna-changelog?

@axelchalon
Copy link
Contributor

sounds good!

@axelchalon axelchalon self-assigned this Jan 18, 2019
@ltfschoen
Copy link
Contributor

ltfschoen commented Jan 19, 2019

We'll need to update lerna, and hopefully soon with dependabot #28

@axelchalon
Copy link
Contributor

Changelogs are now implemented since d80eb90

We're now using lerna version --conventional-commits in the CI to tag and publish a new release. This takes care of two things:

  • Bump the version of the packages and root workspace (incl. dependencies to the other packages within the monorepo) with patch, minor or major automatically depending on the commit messages since the latest tag.
  • Generate CHANGELOG.md at the root and for each package

The only thing we need to do to make this work is respect the specs from https://www.conventionalcommits.org/ (I would suggest squash merging the PRs with a conventional-commits-compliant commit message from now on)

@amaury1093
Copy link
Collaborator Author

amaury1093 commented Jan 22, 2019

Do you know what happens if we don't squash-merge with a conventional commit message? I suppose (and hope) no version bumping would happen?

Edit: just tried, it actually patched the version.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants