Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

[Private transactions] Optimize patching of related private states #10133

Closed
grbIzl opened this issue Jan 4, 2019 · 1 comment
Closed

[Private transactions] Optimize patching of related private states #10133

grbIzl opened this issue Jan 4, 2019 · 1 comment
Labels
A3-stale 🍃 Pull request did not receive any updates in a long time. No review needed at this stage. Close it. F6-refactor 📚 Code needs refactoring.

Comments

@grbIzl
Copy link
Collaborator

grbIzl commented Jan 4, 2019

After implementation of #10086 for every call of the private contract the code patches the states of all available private contracts as well. That leads to performance issue because the original call might not need it.
The following refactoring required:

  • Add a hook in Externalities::call that checks the contract address.
  • From there, only patch an account in the state if it's actually called.
@grbIzl grbIzl added the F6-refactor 📚 Code needs refactoring. label Jan 4, 2019
@grbIzl grbIzl mentioned this issue Jan 4, 2019
Merged
@adria0 adria0 added the A3-stale 🍃 Pull request did not receive any updates in a long time. No review needed at this stage. Close it. label Jul 27, 2020
@adria0
Copy link

adria0 commented Jul 27, 2020

Closing issue due to its stale state.

@adria0 adria0 closed this as completed Jul 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
A3-stale 🍃 Pull request did not receive any updates in a long time. No review needed at this stage. Close it. F6-refactor 📚 Code needs refactoring.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@grbIzl @adria0 and others