Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

HEAD fails to compile due to new_post_eip150() parameter count change #3469

Closed
lhl opened this issue Nov 16, 2016 · 2 comments
Closed

HEAD fails to compile due to new_post_eip150() parameter count change #3469

lhl opened this issue Nov 16, 2016 · 2 comments

Comments

@lhl
Copy link

lhl commented Nov 16, 2016

It looks like this commit ethcore/parity@528bf17 changed Schedule::new_post_eip150() to take 4 instead of 3 parameters.

This is not updated in ethcore/src/engines/authority_round.rs https://github.com/ethcore/parity/blob/1daba384cc57676a620b6545b7707a3b38cb0f73/ethcore/src/engines/authority_round.rs#L193

and causes compilation to fail.

error[E0061]: this function takes 4 parameters but 3 parameters were supplied
   --> ethcore/src/engines/authority_round.rs:193:3
    |
193 | 		Schedule::new_post_eip150(true, true, true)
    | 		^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: the following parameter types were expected:
    = note: usize, bool, bool, bool

error: aborting due to previous error

error: Could not compile `ethcore`.

Looks like it shows up in CI as well, but this must have been failing for the past 5 days?
https://travis-ci.org/ethcore/parity/jobs/176263619#L2875

@arkpar
Copy link
Collaborator

arkpar commented Nov 16, 2016

Fixed in #3470

@arkpar arkpar closed this as completed Nov 16, 2016
@lhl
Copy link
Author

lhl commented Nov 16, 2016

Thanks for the fix, builds now!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants