This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Add benchmark for transaction execution #11509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasad1
reviewed
Feb 24, 2020
niklasad1
reviewed
Feb 24, 2020
niklasad1
reviewed
Feb 24, 2020
niklasad1
reviewed
Feb 24, 2020
niklasad1
reviewed
Feb 24, 2020
niklasad1
reviewed
Feb 24, 2020
niklasad1
reviewed
Feb 24, 2020
| let signed_txs = setup_state_for_block(&mut state, constantinople_block); | ||
| let machine = new_constantinople_test_machine(); | ||
|
|
||
| c.bench_function("apply transactions with tracing (Constantinople)", |b| { |
There was a problem hiding this comment.
the benches seem very similar with the exception that the boolean flag is_checkpoint differs. Is it possible to extract those to a helper function to avoid repeating?
There was a problem hiding this comment.
Hmm, is_checkpoint? Do you mean the tracing bool?
There was a problem hiding this comment.
+1 for extracting the logic that is repeated 4 times
niklasad1
approved these changes
Feb 24, 2020
ordian
approved these changes
Feb 24, 2020
| // You should have received a copy of the GNU General Public License | ||
| // along with Parity Ethereum. If not, see <http://www.gnu.org/licenses/>. | ||
|
|
||
| //! Benchmark transaction execution |
There was a problem hiding this comment.
The tricky part is that the transaction execution depends on the db size, here we're measuring only CPU time as if all the data fits in memory. I think it's worth mentioning in the module docs.
| let signed_txs = setup_state_for_block(&mut state, constantinople_block); | ||
| let machine = new_constantinople_test_machine(); | ||
|
|
||
| c.bench_function("apply transactions with tracing (Constantinople)", |b| { |
There was a problem hiding this comment.
+1 for extracting the logic that is repeated 4 times
Merged
…oth Constantinople and Istanbul rules
ordian
added
A8-looksgood 🦄
dvdplm
deleted the
dp/chore/add-benchmarks-for-transaction-application
branch
dvdplm
added a commit
that referenced
this pull request
Feb 25, 2020
* master: Add benchmark for transaction execution (#11509) Add Smart Contract License v1.0
ordian
added a commit
that referenced
this pull request
Mar 6, 2020
* master: (27 commits) Faster kill_garbage (#11514) [EngineSigner]: don't sign message with only zeroes (#11524) fix compilation warnings (#11522) [ethcore cleanup]: various unrelated fixes from `#11493` (#11507) Add benchmark for transaction execution (#11509) Add Smart Contract License v1.0 Misc fixes (#11510) [dependencies]: unify `rustc-hex` (#11506) Activate on-chain randomness in POA Sokol (#11505) Grab bag of cleanup (#11504) Implement eth/64 (EIP-2364) and drop support for eth/62 (#11472) [dependencies]: remove `util/macros` (#11501) OpenEthereum bootnodes are added (#11499) [ci benches]: use `all-features` (#11496) [verification]: make test-build compile standalone (#11495) complete null-signatures removal (#11491) Include the seal when populating the header for a new block (#11475) fix compilation warnings (#11492) cargo update -p cmake (#11490) update to published rlp-derive (#11489) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmark the
applymethod ofexecutive-stateusing the transactions from two blocks.I backported this to 2.5.13. Results:
Current master: